From: Yicong Yang <yangyicong@hisilicon.com>
To: kbuild test robot <lkp@intel.com>
Cc: <kbuild-all@lists.01.org>, <helgaas@kernel.org>,
<linux-pci@vger.kernel.org>, <f.fangjian@huawei.com>
Subject: Re: [PATCH] PCI: Improve link speed presentation process
Date: Thu, 16 Jan 2020 17:42:22 +0800 [thread overview]
Message-ID: <35f30246-693a-ac44-d0a1-9573a5d2bd7e@hisilicon.com> (raw)
In-Reply-To: <202001161542.CdWrJ2ZG%lkp@intel.com>
Hi Bjorn,
It seems like we have met the problem you indicated, that using pci_bus_speed_strings[] in
PCIE_BUS_SPEED2STR macro is only available when CONFIG_SYSFS=y.
I have moved the string array to probe.c in the new patch set according to the suggestions.
I hope it has not been buried in the mail list.
https://lore.kernel.org/linux-pci/1579079063-5668-1-git-send-email-yangyicong@hisilicon.com/
On 2020/1/16 15:45, kbuild test robot wrote:
> Hi Yicong,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on pci/next]
> [also build test ERROR on v5.5-rc6 next-20200110]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Yicong-Yang/PCI-Improve-link-speed-presentation-process/20200114-163536
> base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
> config: ia64-allnoconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 7.5.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=ia64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/pci/pci-sysfs.o: In function `max_link_speed_show':
>>> pci-sysfs.c:(.text+0x1e01): undefined reference to `pci_bus_speed_strings'
> pci-sysfs.c:(.text+0x1e10): undefined reference to `pci_bus_speed_strings'
> drivers/pci/pci-sysfs.o: In function `current_link_speed_show':
> pci-sysfs.c:(.text+0x2070): undefined reference to `pci_bus_speed_strings'
> pci-sysfs.c:(.text+0x2080): undefined reference to `pci_bus_speed_strings'
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
prev parent reply other threads:[~2020-01-16 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 8:11 [PATCH] PCI: Improve link speed presentation process Yicong Yang
2020-01-14 22:49 ` Bjorn Helgaas
2020-01-16 7:45 ` kbuild test robot
2020-01-16 9:42 ` Yicong Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f30246-693a-ac44-d0a1-9573a5d2bd7e@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=f.fangjian@huawei.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).