From: "Jianjun Wang (王建军)" <Jianjun.Wang@mediatek.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Ryder Lee (李庚諺)" <Ryder.Lee@mediatek.com>,
"TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>,
"Rex-BC Chen (陳柏辰)" <Rex-BC.Chen@mediatek.com>
Subject: Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
Date: Thu, 2 Sep 2021 02:07:34 +0000 [thread overview]
Message-ID: <36c66b737afa96563be128d822f862eea5839dcb.camel@mediatek.com> (raw)
In-Reply-To: <CAL_JsqJTW=ot=BBWQfOj9rJ82dnVV21TpHGf3vieUQ_Jd8i9Rg@mail.gmail.com>
On Mon, 2021-08-30 at 11:02 -0500, Rob Herring wrote:
> On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <
> jianjun.wang@mediatek.com> wrote:
> >
> > MT8195 is an ARM platform SoC which has the same PCIe IP with
> > MT8192.
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
> > +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 742206dbd965..93e09c3029b7 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: mediatek,mt8192-pcie
> > + enum:
> > + - mediatek,mt8192-pcie
> > + - mediatek,mt8195-pcie
>
> I thought you wanted to support 8192 as the fallback:
>
> compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";
>
> The above schema doesn't allow this.
>
> Rob
Hi Rob,
Yes, I want this fallback to support MT8195, but there are some un-
documented warnings if I don't add its compatible string to the yaml
file.
Do you have any suggestions in this case?
Thanks.
prev parent reply other threads:[~2021-09-02 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 2:26 [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
2021-08-30 16:02 ` Rob Herring
2021-09-02 2:07 ` Jianjun Wang (王建军) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c66b737afa96563be128d822f862eea5839dcb.camel@mediatek.com \
--to=jianjun.wang@mediatek.com \
--cc=Rex-BC.Chen@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).