From: Yicong Yang <yangyicong@hisilicon.com>
To: <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
Cc: <f.fangjian@huawei.com>
Subject: Re: [PATCH 0/6] Improve link speed presentation process
Date: Wed, 5 Feb 2020 17:37:38 +0800 [thread overview]
Message-ID: <36d8ddfb-df1a-18cb-bd17-809bf805e8bd@hisilicon.com> (raw)
In-Reply-To: <1579079063-5668-1-git-send-email-yangyicong@hisilicon.com>
Hi Bjorn,
would you mind giving some comments to help me get these patches merged?
Thanks,
Yicong Yang
On 2020/1/15 17:04, Yicong Yang wrote:
> In this series:
> 1. Add 32 GT/s decoding in some macros as a complementary
> 2. Remove redundancy in speed presentation process and improve the codes.
>
> Currently We use switch-case statements to acquire the speed
> string according to the pci bus speed in current_link_speed_show()
> and pcie_get_speed_cap(). It leads to redundant and when new
> standard comes, we have to add cases in the related functions,
> which is easy to omit at somewhere.
>
> Abstract the judge statements out. Use macros and pci speed
> arrays instead. Then only the macros and arrays need to be
> extended when next generation comes.
>
> Link:
> https://lore.kernel.org/linux-pci/20200113211728.GA113776@google.com/
> https://lore.kernel.org/linux-pci/20200114224909.GA19633@google.com/
>
>
> Yicong Yang (6):
> PCI: add 32 GT/s decoding in some macros
> PCI: Make pci_bus_speed_strings[] public
> PCI: Add comments for link speed info arrays
> PCI: Improve and rename PCIE_SPEED2STR macro
> PCI: Add PCIE_LNKCAP2_SLS2SPEED macro
> PCI: Reduce redundancy in current_link_speed_show()
>
> drivers/pci/pci-sysfs.c | 26 ++++----------------------
> drivers/pci/pci.c | 23 +++++++----------------
> drivers/pci/pci.h | 22 +++++++++++++++-------
> drivers/pci/probe.c | 37 +++++++++++++++++++++++++++++++++++++
> drivers/pci/slot.c | 39 +++------------------------------------
> 5 files changed, 66 insertions(+), 81 deletions(-)
>
> --
> 2.8.1
>
>
> .
>
prev parent reply other threads:[~2020-02-05 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 9:04 [PATCH 0/6] Improve link speed presentation process Yicong Yang
2020-01-15 9:04 ` [PATCH 1/6] PCI: add 32 GT/s decoding in some macros Yicong Yang
2020-01-15 9:04 ` [PATCH 2/6] PCI: Make pci_bus_speed_strings[] public Yicong Yang
2020-02-05 18:35 ` Bjorn Helgaas
2020-02-06 1:47 ` Yicong Yang
2020-01-15 9:04 ` [PATCH 3/6] PCI: Add comments for link speed info arrays Yicong Yang
2020-01-15 9:04 ` [PATCH 4/6] PCI: Improve and rename PCIE_SPEED2STR macro Yicong Yang
2020-02-05 18:50 ` Bjorn Helgaas
2020-02-06 1:50 ` Yicong Yang
2020-01-15 9:04 ` [PATCH 5/6] PCI: Add PCIE_LNKCAP2_SLS2SPEED macro Yicong Yang
2020-02-05 18:54 ` Bjorn Helgaas
2020-02-06 1:53 ` Yicong Yang
2020-01-15 9:04 ` [PATCH 6/6] PCI: Reduce redundancy in current_link_speed_show() Yicong Yang
2020-02-05 9:37 ` Yicong Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d8ddfb-df1a-18cb-bd17-809bf805e8bd@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=f.fangjian@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).