From: Logan Gunthorpe <logang@deltatee.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kselftest@vger.kernel.org, Jon Mason <jdmason@kudzu.us>,
Bjorn Helgaas <bhelgaas@google.com>,
Allen Hubbe <allenbh@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
Serge Semin <fancer.lancer@gmail.com>,
Eric Pilmore <epilmore@gigaio.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices
Date: Fri, 1 Feb 2019 10:27:29 -0700 [thread overview]
Message-ID: <398e6a0a-9cbd-c218-e20e-ed91f74a653d@deltatee.com> (raw)
In-Reply-To: <20190201164401.GT32526@8bytes.org>
On 2019-02-01 9:44 a.m., Joerg Roedel wrote:
> On Thu, Jan 31, 2019 at 11:56:48AM -0700, Logan Gunthorpe wrote:
>> @@ -394,6 +402,10 @@ static int set_msi_sid(struct irte *irte, struct pci_dev *dev)
>> set_irte_sid(irte, SVT_VERIFY_BUS, SQ_ALL_16,
>> PCI_DEVID(PCI_BUS_NUM(data.alias),
>> dev->bus->number));
>> + else if (data.count >= 2 && data.busmatch_count == data.count)
>> + set_irte_sid(irte, SVT_VERIFY_BUS, SQ_ALL_16,
>> + PCI_DEVID(dev->bus->number,
>> + dev->bus->number));
>
> The dev->bus->number argument for the devfn parameter of PCI_DEVID is
> not needed, right?
Oh, yes. I think you are right.
> Also, this requires at least a comment to document that special case.
I'll add a comment for v2.
Thanks for the review!
Logan
next prev parent reply other threads:[~2019-02-01 17:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:56 [PATCH 0/9] Support using MSI interrupts in ntb_transport Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices Logan Gunthorpe
2019-02-01 16:44 ` Joerg Roedel
2019-02-01 17:27 ` Logan Gunthorpe [this message]
2019-02-05 19:19 ` Jacob Pan
2019-02-05 20:40 ` Logan Gunthorpe
2019-02-05 23:58 ` Jacob Pan
2019-01-31 18:56 ` [PATCH 2/9] PCI/MSI: Support allocating virtual MSI interrupts Logan Gunthorpe
2019-01-31 22:39 ` Bjorn Helgaas
2019-01-31 22:52 ` Logan Gunthorpe
2019-02-01 19:23 ` Bjorn Helgaas
2019-01-31 18:56 ` [PATCH 3/9] PCI/switchtec: Add module parameter to request more interrupts Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 4/9] NTB: Introduce functions to calculate multi-port resource index Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 5/9] NTB: Rename ntb.c to support multiple source files in the module Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 6/9] NTB: Introduce MSI library Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 7/9] NTB: Introduce NTB MSI Test Client Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 8/9] NTB: Add ntb_msi_test support to ntb_test Logan Gunthorpe
2019-01-31 18:56 ` [PATCH 9/9] NTB: Add MSI interrupt support to ntb_transport Logan Gunthorpe
2019-01-31 20:20 ` [PATCH 0/9] Support using MSI interrupts in ntb_transport Dave Jiang
2019-01-31 20:48 ` Logan Gunthorpe
2019-01-31 20:58 ` Dave Jiang
2019-01-31 22:39 ` Logan Gunthorpe
2019-01-31 22:46 ` Dave Jiang
2019-01-31 23:41 ` Logan Gunthorpe
2019-01-31 23:48 ` Dave Jiang
2019-01-31 23:52 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=398e6a0a-9cbd-c218-e20e-ed91f74a653d@deltatee.com \
--to=logang@deltatee.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=dwmw2@infradead.org \
--cc=epilmore@gigaio.com \
--cc=fancer.lancer@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jdmason@kudzu.us \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).