linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>, <ruscur@russell.cc>,
	Linux PCI <linux-pci@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] PCI/AER: Correct function names in the header
Date: Fri, 26 Mar 2021 08:58:24 +0800	[thread overview]
Message-ID: <39a66394-cd74-ebff-7447-cb9fa51d8db4@huawei.com> (raw)
In-Reply-To: <CAJZ5v0hgsuv8NwuhtK4CrdjPT_VMz1Dp4bDeYtEQs3qeJN_Uhg@mail.gmail.com>

Hi Rafael,

On 2021/3/26 1:30, Rafael J. Wysocki wrote:
> On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang
> <wangxiongfeng2@huawei.com> wrote:
>>
>> Fixes the following W=1 kernel build warning(s):
>>
>>  drivers/pci/pcie/aer.c:138: warning: expecting prototype for enable_ercr_checking(). Prototype was for enable_ecrc_checking() instead
>>  drivers/pci/pcie/aer.c:162: warning: expecting prototype for disable_ercr_checking(). Prototype was for disable_ecrc_checking() instead
>>  drivers/pci/pcie/aer.c:1450: warning: expecting prototype for aer_service_init(). Prototype was for pcie_aer_init() instead
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> 
> The subject is somewhat inaccurate, because you're fixing function
> names in kerneldoc comments.
> 
> If you say "a header", people may think that this is about a header file.

Thanks a lot ! I will change it in the next version.

Thanks,
Xiongfeng

> 
>> ---
>>  drivers/pci/pcie/aer.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
>> index ba22388342d1..ec943cee5ecc 100644
>> --- a/drivers/pci/pcie/aer.c
>> +++ b/drivers/pci/pcie/aer.c
>> @@ -129,7 +129,7 @@ static const char * const ecrc_policy_str[] = {
>>  };
>>
>>  /**
>> - * enable_ercr_checking - enable PCIe ECRC checking for a device
>> + * enable_ecrc_checking - enable PCIe ECRC checking for a device
>>   * @dev: the PCI device
>>   *
>>   * Returns 0 on success, or negative on failure.
>> @@ -153,7 +153,7 @@ static int enable_ecrc_checking(struct pci_dev *dev)
>>  }
>>
>>  /**
>> - * disable_ercr_checking - disables PCIe ECRC checking for a device
>> + * disable_ecrc_checking - disables PCIe ECRC checking for a device
>>   * @dev: the PCI device
>>   *
>>   * Returns 0 on success, or negative on failure.
>> @@ -1442,7 +1442,7 @@ static struct pcie_port_service_driver aerdriver = {
>>  };
>>
>>  /**
>> - * aer_service_init - register AER root service driver
>> + * pcie_aer_init - register AER root service driver
>>   *
>>   * Invoked when AER root service driver is loaded.
>>   */
>> --
>> 2.20.1
>>
> .
> 

  reply	other threads:[~2021-03-26  0:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  7:51 [PATCH 0/4] PCI: " Xiongfeng Wang
2021-03-25  7:51 ` [PATCH 1/4] PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name " Xiongfeng Wang
2021-03-25 17:31   ` Rafael J. Wysocki
2021-03-25  7:51 ` [PATCH 2/4] PCI/AER: Correct function names " Xiongfeng Wang
2021-03-25 17:30   ` Rafael J. Wysocki
2021-03-26  0:58     ` Xiongfeng Wang [this message]
2021-03-25  7:51 ` [PATCH 3/4] PCI/PME: Correct pcie_pme_init() function name " Xiongfeng Wang
2021-03-25  7:51 ` [PATCH 4/4] PCI/ATS: Correct pci_max_pasids() function name in header Xiongfeng Wang
2021-03-26  1:07 ` [PATCH 0/4] PCI: Correct function names in the header Krzysztof Wilczyński
2021-03-27  8:17   ` Xiongfeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39a66394-cd74-ebff-7447-cb9fa51d8db4@huawei.com \
    --to=wangxiongfeng2@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=ruscur@russell.cc \
    --subject='Re: [PATCH 2/4] PCI/AER: Correct function names in the header' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).