Xiongfeng Wang (4): PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in the header PCI/AER: Correct function names in the header PCI/PME: Correct pcie_pme_init() function name in the header PCI/ATS: Correct pci_max_pasids() function name in header drivers/pci/ats.c | 2 +- drivers/pci/hotplug/acpi_pcihp.c | 2 +- drivers/pci/pcie/aer.c | 6 +++--- drivers/pci/pcie/pme.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) -- 2.20.1
Fixes the following W=1 kernel build warning(s): drivers/pci/hotplug/acpi_pcihp.c:167: warning: expecting prototype for acpi_pcihp_check_ejectable(). Prototype was for acpi_pci_check_ejectable() instead Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> --- drivers/pci/hotplug/acpi_pcihp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c index 2750a64cecd3..4fedebf2f8c1 100644 --- a/drivers/pci/hotplug/acpi_pcihp.c +++ b/drivers/pci/hotplug/acpi_pcihp.c @@ -157,7 +157,7 @@ static int pcihp_is_ejectable(acpi_handle handle) } /** - * acpi_pcihp_check_ejectable - check if handle is ejectable ACPI PCI slot + * acpi_pci_check_ejectable - check if handle is ejectable ACPI PCI slot * @pbus: the PCI bus of the PCI slot corresponding to 'handle' * @handle: ACPI handle to check * -- 2.20.1
Fixes the following W=1 kernel build warning(s): drivers/pci/pcie/aer.c:138: warning: expecting prototype for enable_ercr_checking(). Prototype was for enable_ecrc_checking() instead drivers/pci/pcie/aer.c:162: warning: expecting prototype for disable_ercr_checking(). Prototype was for disable_ecrc_checking() instead drivers/pci/pcie/aer.c:1450: warning: expecting prototype for aer_service_init(). Prototype was for pcie_aer_init() instead Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> --- drivers/pci/pcie/aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index ba22388342d1..ec943cee5ecc 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -129,7 +129,7 @@ static const char * const ecrc_policy_str[] = { }; /** - * enable_ercr_checking - enable PCIe ECRC checking for a device + * enable_ecrc_checking - enable PCIe ECRC checking for a device * @dev: the PCI device * * Returns 0 on success, or negative on failure. @@ -153,7 +153,7 @@ static int enable_ecrc_checking(struct pci_dev *dev) } /** - * disable_ercr_checking - disables PCIe ECRC checking for a device + * disable_ecrc_checking - disables PCIe ECRC checking for a device * @dev: the PCI device * * Returns 0 on success, or negative on failure. @@ -1442,7 +1442,7 @@ static struct pcie_port_service_driver aerdriver = { }; /** - * aer_service_init - register AER root service driver + * pcie_aer_init - register AER root service driver * * Invoked when AER root service driver is loaded. */ -- 2.20.1
Fixes the following W=1 kernel build warning(s): drivers/pci/pcie/pme.c:469: warning: expecting prototype for pcie_pme_service_init(). Prototype was for pcie_pme_init() instead Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> --- drivers/pci/pcie/pme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index 3fc08488d65f..1d0dd77fed3a 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c @@ -463,7 +463,7 @@ static struct pcie_port_service_driver pcie_pme_driver = { }; /** - * pcie_pme_service_init - Register the PCIe PME service driver. + * pcie_pme_init - Register the PCIe PME service driver. */ int __init pcie_pme_init(void) { -- 2.20.1
Fixes the following W=1 kernel build warning(s): drivers/pci/ats.c:490: warning: expecting prototype for pci_max_pasid(). Prototype was for pci_max_pasids() instead Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> --- drivers/pci/ats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 0d3719407b8b..6d7d64939f82 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -480,7 +480,7 @@ EXPORT_SYMBOL_GPL(pci_pasid_features); #define PASID_NUMBER_SHIFT 8 #define PASID_NUMBER_MASK (0x1f << PASID_NUMBER_SHIFT) /** - * pci_max_pasid - Get maximum number of PASIDs supported by device + * pci_max_pasids - Get maximum number of PASIDs supported by device * @pdev: PCI device structure * * Returns negative value when PASID capability is not present. -- 2.20.1
On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang <wangxiongfeng2@huawei.com> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/pci/pcie/aer.c:138: warning: expecting prototype for enable_ercr_checking(). Prototype was for enable_ecrc_checking() instead > drivers/pci/pcie/aer.c:162: warning: expecting prototype for disable_ercr_checking(). Prototype was for disable_ecrc_checking() instead > drivers/pci/pcie/aer.c:1450: warning: expecting prototype for aer_service_init(). Prototype was for pcie_aer_init() instead > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> The subject is somewhat inaccurate, because you're fixing function names in kerneldoc comments. If you say "a header", people may think that this is about a header file. > --- > drivers/pci/pcie/aer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index ba22388342d1..ec943cee5ecc 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -129,7 +129,7 @@ static const char * const ecrc_policy_str[] = { > }; > > /** > - * enable_ercr_checking - enable PCIe ECRC checking for a device > + * enable_ecrc_checking - enable PCIe ECRC checking for a device > * @dev: the PCI device > * > * Returns 0 on success, or negative on failure. > @@ -153,7 +153,7 @@ static int enable_ecrc_checking(struct pci_dev *dev) > } > > /** > - * disable_ercr_checking - disables PCIe ECRC checking for a device > + * disable_ecrc_checking - disables PCIe ECRC checking for a device > * @dev: the PCI device > * > * Returns 0 on success, or negative on failure. > @@ -1442,7 +1442,7 @@ static struct pcie_port_service_driver aerdriver = { > }; > > /** > - * aer_service_init - register AER root service driver > + * pcie_aer_init - register AER root service driver > * > * Invoked when AER root service driver is loaded. > */ > -- > 2.20.1 >
On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang <wangxiongfeng2@huawei.com> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/pci/hotplug/acpi_pcihp.c:167: warning: expecting prototype for acpi_pcihp_check_ejectable(). Prototype was for acpi_pci_check_ejectable() instead > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> > --- > drivers/pci/hotplug/acpi_pcihp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c > index 2750a64cecd3..4fedebf2f8c1 100644 > --- a/drivers/pci/hotplug/acpi_pcihp.c > +++ b/drivers/pci/hotplug/acpi_pcihp.c > @@ -157,7 +157,7 @@ static int pcihp_is_ejectable(acpi_handle handle) > } > > /** > - * acpi_pcihp_check_ejectable - check if handle is ejectable ACPI PCI slot > + * acpi_pci_check_ejectable - check if handle is ejectable ACPI PCI slot Again, this is about fixing a kerneldoc comment, so please change the subject to reflect that more precisely. This applies to all of the patches in the series AFAICS. > * @pbus: the PCI bus of the PCI slot corresponding to 'handle' > * @handle: ACPI handle to check > * > -- > 2.20.1 >
Hi Rafael, On 2021/3/26 1:30, Rafael J. Wysocki wrote: > On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang > <wangxiongfeng2@huawei.com> wrote: >> >> Fixes the following W=1 kernel build warning(s): >> >> drivers/pci/pcie/aer.c:138: warning: expecting prototype for enable_ercr_checking(). Prototype was for enable_ecrc_checking() instead >> drivers/pci/pcie/aer.c:162: warning: expecting prototype for disable_ercr_checking(). Prototype was for disable_ecrc_checking() instead >> drivers/pci/pcie/aer.c:1450: warning: expecting prototype for aer_service_init(). Prototype was for pcie_aer_init() instead >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> > > The subject is somewhat inaccurate, because you're fixing function > names in kerneldoc comments. > > If you say "a header", people may think that this is about a header file. Thanks a lot ! I will change it in the next version. Thanks, Xiongfeng > >> --- >> drivers/pci/pcie/aer.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c >> index ba22388342d1..ec943cee5ecc 100644 >> --- a/drivers/pci/pcie/aer.c >> +++ b/drivers/pci/pcie/aer.c >> @@ -129,7 +129,7 @@ static const char * const ecrc_policy_str[] = { >> }; >> >> /** >> - * enable_ercr_checking - enable PCIe ECRC checking for a device >> + * enable_ecrc_checking - enable PCIe ECRC checking for a device >> * @dev: the PCI device >> * >> * Returns 0 on success, or negative on failure. >> @@ -153,7 +153,7 @@ static int enable_ecrc_checking(struct pci_dev *dev) >> } >> >> /** >> - * disable_ercr_checking - disables PCIe ECRC checking for a device >> + * disable_ecrc_checking - disables PCIe ECRC checking for a device >> * @dev: the PCI device >> * >> * Returns 0 on success, or negative on failure. >> @@ -1442,7 +1442,7 @@ static struct pcie_port_service_driver aerdriver = { >> }; >> >> /** >> - * aer_service_init - register AER root service driver >> + * pcie_aer_init - register AER root service driver >> * >> * Invoked when AER root service driver is loaded. >> */ >> -- >> 2.20.1 >> > . >
Hi, [...] > PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in > the header > PCI/AER: Correct function names in the header > PCI/PME: Correct pcie_pme_init() function name in the header > PCI/ATS: Correct pci_max_pasids() function name in header [...] All of this has already been fixed in the following series: https://lore.kernel.org/linux-pci/20210311001724.423356-1-kw@linux.com/ Krzysztof
Hi, Krzysztof On 2021/3/26 9:07, Krzysztof Wilczyński wrote: > Hi, > > [...] >> PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in >> the header >> PCI/AER: Correct function names in the header >> PCI/PME: Correct pcie_pme_init() function name in the header >> PCI/ATS: Correct pci_max_pasids() function name in header > [...] > > All of this has already been fixed in the following series: > > https://lore.kernel.org/linux-pci/20210311001724.423356-1-kw@linux.com/ Thanks for your remind. I will skip this series in the future. Thanks, Xiongfeng > > Krzysztof > . >