From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Iain Lane <iain@orangesquash.org.uk>,
Shyam-sundar S-k <Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH v11 8/9] PCI: Split PME state selection into a local static function
Date: Fri, 11 Aug 2023 07:40:08 -0500 [thread overview]
Message-ID: <3d13c3b2-fdb8-4782-ada5-cf3f94e0e643@amd.com> (raw)
In-Reply-To: <ZNX3n5rHBHkN4kZy@smile.fi.intel.com>
On 8/11/2023 3:55 AM, Andy Shevchenko wrote:
> On Thu, Aug 10, 2023 at 11:29:49AM -0500, Limonciello, Mario wrote:
>> On 8/10/2023 11:21 AM, Andy Shevchenko wrote:
>>> On Wed, Aug 09, 2023 at 01:54:52PM -0500, Mario Limonciello wrote:
>
> ...
>
>>>> +static inline pci_power_t pci_get_wake_pme_state(struct pci_dev *dev)
>>>> +{
>>>> + pci_power_t state = PCI_D3hot;
>>>> +
>>>> + while (state && !(dev->pme_support & (1 << state)))
>>>> + state--;
>>>> +
>>>> + return state;
>>>
>>> Sparse won't be happy about this code (with CF=-D__CHECK_ENDIAN__).
>>>
>>> Basically it's something like
>>>
>>> return (__force pci_power_t)fls(dev->pme_support & GENMASK(PCI_D3hot, 0));
>>>
>>> (but double check and test the logic).
>>>
>>>> +}
>>>
>>> ...
>>>
>>> Yeah, I see that is the existing code, perhaps amend it first?
>>>
>>
>> Are you sure?
>
> Yes.
>
> Just the original code
>
> drivers/pci/pci.c:2711:60: warning: restricted pci_power_t degrades to integer
> drivers/pci/pci.c:2712:30: warning: restricted pci_power_t degrades to integer
>
> /*
> * Find the deepest state from which the device can generate
> * PME#.
> */
> 2711 ==> while (state && !(dev->pme_support & (1 << state)))
> 2712 ==> state--;
>
> How is yours different?
>
>> I actually double checked the sparse output using this
>> command before I sent it.
>>
>> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' drivers/pci/pci.o
>>
>> I didn't see anything related to the line numbers for this function.
>
> Just in case...
>
> $ gcc --version
> gcc (Debian 12.3.0-5) 12.3.0
>
> $ sparse --version
> 0.6.4 (Debian: 0.6.4-3)
>
> $ make --version
> GNU Make 4.3
> Built for x86_64-pc-linux-gnu
>
Oh, I see why I wasn't observing it now. Because it's inline code it's
processed separately and isn't with the rest of the grouped output from
2416 through 2922.
drivers/pci/pci.c:2679:52: sparse: warning: restricted pci_power_t
degrades to integer
drivers/pci/pci.c:2680:22: sparse: warning: restricted pci_power_t
degrades to integer
next prev parent reply other threads:[~2023-08-11 12:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:54 [PATCH v11 0/9] Fix wakeup problems on some AMD platforms Mario Limonciello
2023-08-09 18:54 ` [PATCH v11 1/9] ACPI: Add comments to clarify some #ifdef statements Mario Limonciello
2023-08-09 18:54 ` [PATCH v11 2/9] ACPI: Adjust #ifdef for *_lps0_dev use Mario Limonciello
2023-08-15 18:28 ` Bjorn Helgaas
2023-08-15 18:32 ` Mario Limonciello
2023-08-16 16:57 ` Bjorn Helgaas
2023-08-09 18:54 ` [PATCH v11 3/9] ACPI: x86: s2idle: Fix a logic error parsing AMD constraints table Mario Limonciello
2023-08-15 19:20 ` Bjorn Helgaas
2023-08-09 18:54 ` [PATCH v11 4/9] ACPI: x86: s2idle: Add more debugging for AMD constraints parsing Mario Limonciello
2023-08-09 18:54 ` [PATCH v11 5/9] ACPI: x86: s2idle: Store if constraint is enabled Mario Limonciello
2023-08-09 18:54 ` [PATCH v11 6/9] ACPI: x86: s2idle: Add a function to get constraints for a device Mario Limonciello
2023-08-10 15:47 ` Andy Shevchenko
2023-08-10 15:54 ` Limonciello, Mario
2023-08-10 15:58 ` Andy Shevchenko
2023-08-09 18:54 ` [PATCH v11 7/9] PCI: ACPI: Add helper functions for converting ACPI <->PCI states Mario Limonciello
2023-08-09 18:54 ` [PATCH v11 8/9] PCI: Split PME state selection into a local static function Mario Limonciello
2023-08-10 16:21 ` Andy Shevchenko
2023-08-10 16:29 ` Limonciello, Mario
2023-08-11 8:55 ` Andy Shevchenko
2023-08-11 12:40 ` Limonciello, Mario [this message]
2023-08-09 18:54 ` [PATCH v11 9/9] PCI: ACPI: Use device constraints to decide PCI target state fallback policy Mario Limonciello
2023-08-15 23:48 ` Bjorn Helgaas
2023-08-16 12:57 ` Limonciello, Mario
2023-08-16 22:38 ` Bjorn Helgaas
2023-08-17 1:26 ` Limonciello, Mario
2023-08-17 12:13 ` Rafael J. Wysocki
2023-08-17 18:31 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d13c3b2-fdb8-4782-ada5-cf3f94e0e643@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=iain@orangesquash.org.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).