linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Derrick <jonathan.derrick@linux.dev>
To: korantwork@gmail.com, nirmal.patel@linux.intel.com,
	lpieralisi@kernel.org
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xinghui Li <korantli@tencent.com>
Subject: Re: [PATCH] PCI: vmd: Do not disable MSI-X remapping in VMD 28C0 controller
Date: Thu, 22 Dec 2022 02:15:20 -0700	[thread overview]
Message-ID: <3d1834d9-7905-1225-741a-f298dd5b8a8e@linux.dev> (raw)
In-Reply-To: <20221222072603.1175248-1-korantwork@gmail.com>



On 12/22/22 12:26 AM, korantwork@gmail.com wrote:
> From: Xinghui Li <korantli@tencent.com>
> 
> Commit ee81ee84f873("PCI: vmd: Disable MSI-X remapping when possible")
> disable the vmd MSI-X remapping for optimizing pci performance.However,
> this feature severely negatively optimized performance in multi-disk
> situations.
> 
> In FIO 4K random test, we test 1 disk in the 1 CPU
> 
> when disable MSI-X remapping:
> read: IOPS=1183k, BW=4622MiB/s (4847MB/s)(1354GiB/300001msec)
> READ: bw=4622MiB/s (4847MB/s), 4622MiB/s-4622MiB/s (4847MB/s-4847MB/s),
> io=1354GiB (1454GB), run=300001-300001msec
> 
> When not disable MSI-X remapping:
> read: IOPS=1171k, BW=4572MiB/s (4795MB/s)(1340GiB/300001msec)
> READ: bw=4572MiB/s (4795MB/s), 4572MiB/s-4572MiB/s (4795MB/s-4795MB/s),
> io=1340GiB (1438GB), run=300001-300001msec
> 
> However, the bypass mode could increase the interrupts costs in CPU.
> We test 12 disks in the 6 CPU,
Well the bypass mode was made to improve performance where you have >4 
drives so this is pretty surprising. With bypass mode disabled, VMD will 
intercept and forward interrupts, increasing costs.

I think Nirmal would want to to understand if there's some other factor 
going on here.

> 
> When disable MSI-X remapping:
> read: IOPS=562k, BW=2197MiB/s (2304MB/s)(644GiB/300001msec)
> READ: bw=2197MiB/s (2304MB/s), 2197MiB/s-2197MiB/s (2304MB/s-2304MB/s),
> io=644GiB (691GB), run=300001-300001msec
> 
> When not disable MSI-X remapping:
> read: IOPS=1144k, BW=4470MiB/s (4687MB/s)(1310GiB/300005msec)
> READ: bw=4470MiB/s (4687MB/s), 4470MiB/s-4470MiB/s (4687MB/s-4687MB/s),
> io=1310GiB (1406GB), run=300005-300005msec
> 
> Signed-off-by: Xinghui Li <korantli@tencent.com>
> ---
>   drivers/pci/controller/vmd.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index e06e9f4fc50f..9f6e9324d67d 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -998,8 +998,7 @@ static const struct pci_device_id vmd_ids[] = {
>   		.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP,},
>   	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
>   		.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
> -				VMD_FEAT_HAS_BUS_RESTRICTIONS |
> -				VMD_FEAT_CAN_BYPASS_MSI_REMAP,},
> +				VMD_FEAT_HAS_BUS_RESTRICTIONS,},
>   	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x467f),
>   		.driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
>   				VMD_FEAT_HAS_BUS_RESTRICTIONS |

  reply	other threads:[~2022-12-22  9:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22  7:26 [PATCH] PCI: vmd: Do not disable MSI-X remapping in VMD 28C0 controller korantwork
2022-12-22  9:15 ` Jonathan Derrick [this message]
2022-12-22 21:56   ` Keith Busch
2022-12-23  8:02     ` Xinghui Li
2022-12-27 22:32       ` Jonathan Derrick
2022-12-28  2:19         ` Xinghui Li
2023-01-09 21:00           ` Jonathan Derrick
2023-01-10 12:28             ` Xinghui Li
2023-02-06 12:45               ` Xinghui Li
2023-02-06 18:11                 ` Patel, Nirmal
2023-02-06 18:28                   ` Keith Busch
2023-02-07  3:18                     ` Xinghui Li
2023-02-07 20:32                       ` Patel, Nirmal
2023-02-09 12:05                         ` Xinghui Li
2023-02-09 23:05                         ` Keith Busch
2023-02-09 23:57                           ` Patel, Nirmal
2023-02-10  0:47                             ` Keith Busch
2022-12-23  7:53   ` Xinghui Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d1834d9-7905-1225-741a-f298dd5b8a8e@linux.dev \
    --to=jonathan.derrick@linux.dev \
    --cc=korantli@tencent.com \
    --cc=korantwork@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=nirmal.patel@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).