From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Shashank Babu Chinta Venkata <quic_schintav@quicinc.com>,
agross@kernel.org, andersson@kernel.org, mani@kernel.org
Cc: quic_msarkar@quicinc.com, quic_kraravin@quicinc.com,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/3] PCI: qcom: Add equalization settings for 16GT/s
Date: Tue, 23 Apr 2024 00:59:05 +0200 [thread overview]
Message-ID: <3f595432-83ad-4513-a24e-87e8ed45eba6@linaro.org> (raw)
In-Reply-To: <20240419001013.28788-3-quic_schintav@quicinc.com>
On 4/19/24 02:09, Shashank Babu Chinta Venkata wrote:
> GEN3_RELATED_OFFSET is being used to determine data rate of shadow
> registers. Select data rate as 16GT/s and set appropriate equilization
> settings to improve link stability for 16GT/s data rate.
>
> Signed-off-by: Shashank Babu Chinta Venkata <quic_schintav@quicinc.com>
> ---
[...]
> + reg = dw_pcie_readl_dbi(pci, GEN3_EQ_FB_MODE_DIR_CHANGE_OFF);
> + reg = GEN3_EQ_FMDC_T_MIN_PHASE23(0) |
> + GEN3_EQ_FMDC_N_EVALS(0xD) |
> + GEN3_EQ_FMDC_MAX_PRE_CUSROR_DELTA(0x5) |
> + GEN3_EQ_FMDC_MAX_POST_CUSROR_DELTA(0x5);
> + dw_pcie_writel_dbi(pci, GEN3_EQ_FB_MODE_DIR_CHANGE_OFF, reg);
> +
> + reg = dw_pcie_readl_dbi(pci, GEN3_EQ_CONTROL_OFF);
> + reg = GEN3_EQ_CONTROL_OFF_FB_MODE(0) |
> + GEN3_EQ_CONTROL_OFF_PHASE23_EXIT_MODE(0) |
> + GEN3_EQ_CONTROL_OFF_FOM_INC_INITIAL_EVAL(0) |
> + GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC(0);
> + dw_pcie_writel_dbi(pci, GEN3_EQ_CONTROL_OFF, reg);
Also, any chance we could get some explanations as to what these magic values mean?
Preferably in the form of a #define for each one
Konrad
next prev parent reply other threads:[~2024-04-22 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 0:09 [PATCH v3 0/3] Add 16GT/s equalization and margining settings Shashank Babu Chinta Venkata
2024-04-19 0:09 ` [PATCH v3 1/3] PCI: qcom: Refactor common code Shashank Babu Chinta Venkata
2024-04-22 14:58 ` Manivannan Sadhasivam
2024-04-19 0:09 ` [PATCH v3 2/3] PCI: qcom: Add equalization settings for 16GT/s Shashank Babu Chinta Venkata
2024-04-22 15:16 ` Manivannan Sadhasivam
2024-04-22 22:59 ` Konrad Dybcio [this message]
2024-04-19 0:09 ` [PATCH v3 3/3] PCI: qcom: Add rx margining " Shashank Babu Chinta Venkata
2024-04-22 15:20 ` Manivannan Sadhasivam
2024-04-22 22:58 ` Konrad Dybcio
2024-04-30 20:37 ` Shashank Babu Chinta Venkata
2024-05-01 23:13 ` Konrad Dybcio
2024-04-19 7:36 ` [PATCH v3 0/3] Add 16GT/s equalization and margining settings Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f595432-83ad-4513-a24e-87e8ed45eba6@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor.dooley@microchip.com \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_kraravin@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_schintav@quicinc.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).