From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABC6C433F5 for ; Tue, 1 Mar 2022 08:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233417AbiCAIua (ORCPT ); Tue, 1 Mar 2022 03:50:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231737AbiCAIu3 (ORCPT ); Tue, 1 Mar 2022 03:50:29 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C935189304 for ; Tue, 1 Mar 2022 00:49:49 -0800 (PST) Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 784023FCAA for ; Tue, 1 Mar 2022 08:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646124588; bh=i5oNvJtWT2nQMVMnHuzSOVOeJhkbSN882hqbqowwmW8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hAPDoKJkdI9ov0HfkFPeWTN9mV733EHTIkgwDtxCO0GE9OFp2MH9B6JhRS45U+Mex ddtFQPoaurROokMYEkeUhvJeJKYFx2n/x3+B+VYcZtbaC94c4gUtt4JRPE+5vyQXFE 3KgDX6FZ5d+vF1rjy8n9tNNxMP/PsR5fdgAm/150K82k9junmHj/eaNuBsLXUz8adP 3Q7c0T+S076u/cJTGgIsjzBub9T5nAzkvYJ20j7SLDi9zQ+zGZp5YgAevtYJbF7/k0 PTeYx5ZaL5tEVZKKrjY4X7n3ibw+sXtqcUlYQ0o/Mh4S6iwGQ7JHe1TtOwzwtliv9u +Iii2om+F+aWA== Received: by mail-lf1-f69.google.com with SMTP id g13-20020a056512118d00b00445ade9f7fbso268071lfr.2 for ; Tue, 01 Mar 2022 00:49:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=i5oNvJtWT2nQMVMnHuzSOVOeJhkbSN882hqbqowwmW8=; b=6o3DFv9cDiFwyNE5NzAKp/hJXgiv6e/8/RxkLoZckIDSdmfIck3YNA4wfTR0pmO1JL oqIJsCxR573/TLUaSAcD+GfvKeOLn+DKLbAXAGeIICZZDdOJ1jFfZyRWCvO0uqaQ7HMN VPrhCpX+u1Y2sI8DuGQu4HM1QwL32qT7CpOTfjuGdgBYOHF+Y3ORWbaaUUepMsEOac4l hncGK7SU2g9nrwmkC6XUFxjbqMdnmKtXDtE3C5uvceE3Tb3MgU+dmbgKKZogExfh/NUt xKZgHKNzFw/0btsiLvnFDLSSKYx+5V+9PnyLFNRAPfRiKm2+kvUKOJplkeRPouBcxlhQ r1zQ== X-Gm-Message-State: AOAM530pJm0Vx8rKlO+zr4BZQ2wL0I7bFkKHBd2gbNOnX4JhHcwjVsw8 V0hvqrMXuaH2vPNfpkw/VW+308RqfUrM1yCGlHSgtrFCz+ulr9X9FTepOiZJg3ssvQqSTt8ey2d NfBQrFv5a80DeYkIBz1OITFRxLU8pE4v1dvgKDg== X-Received: by 2002:aa7:db47:0:b0:413:7649:c2bb with SMTP id n7-20020aa7db47000000b004137649c2bbmr18696651edt.123.1646124577531; Tue, 01 Mar 2022 00:49:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0Ji57X8BPtLBdo02/7Aw5hrJyfazNqZcwT3ns08IlVBGD/uW7vhmHoqEKLaS5kqGFV7Hlhw== X-Received: by 2002:aa7:db47:0:b0:413:7649:c2bb with SMTP id n7-20020aa7db47000000b004137649c2bbmr18696608edt.123.1646124577357; Tue, 01 Mar 2022 00:49:37 -0800 (PST) Received: from [192.168.0.136] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id y14-20020a50eb8e000000b00410a2e7798dsm6893213edr.38.2022.03.01.00.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Mar 2022 00:49:36 -0800 (PST) Message-ID: <40d9b2ad-2f8a-42c8-54cf-b22e24d78538@canonical.com> Date: Tue, 1 Mar 2022 09:49:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 01/11] driver: platform: Add helper for safer setting of driver_override Content-Language: en-US To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220228200326.GA516164@bhelgaas> From: Krzysztof Kozlowski In-Reply-To: <20220228200326.GA516164@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 28/02/2022 21:03, Bjorn Helgaas wrote: > On Sun, Feb 27, 2022 at 02:52:04PM +0100, Krzysztof Kozlowski wrote: >> Several core drivers and buses expect that driver_override is a >> dynamically allocated memory thus later they can kfree() it. > >> +int driver_set_override(struct device *dev, const char **override, >> + const char *s, size_t len) >> +{ >> + const char *new, *old; >> + char *cp; >> + >> + if (!dev || !override || !s) >> + return -EINVAL; >> + >> + /* We need to keep extra room for a newline */ > > It would help a lot to extend this comment with a hint about where the > room for a newline is needed. It was confusing even before, but it's > much more so now that the check is in a completely different file than > the "show" functions that need the space. > Indeed, this needs explanation. Best regards, Krzysztof