From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5133DC31E49 for ; Thu, 13 Jun 2019 15:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 346A320851 for ; Thu, 13 Jun 2019 15:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731733AbfFMPyc (ORCPT ); Thu, 13 Jun 2019 11:54:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47397 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390115AbfFMPy3 (ORCPT ); Thu, 13 Jun 2019 11:54:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C5F033086204; Thu, 13 Jun 2019 15:54:24 +0000 (UTC) Received: from [10.36.116.67] (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7664E6061E; Thu, 13 Jun 2019 15:54:15 +0000 (UTC) Subject: Re: [PATCH v8 0/7] Add virtio-iommu driver To: Jean-Philippe Brucker , joro@8bytes.org, mst@redhat.com Cc: iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jasowang@redhat.com, robh+dt@kernel.org, mark.rutland@arm.com, Lorenzo.Pieralisi@arm.com, robin.murphy@arm.com, bhelgaas@google.com, frowand.list@gmail.com, kvmarm@lists.cs.columbia.edu, Tomasz Nowicki , kevin.tian@intel.com, bauerman@linux.ibm.com References: <20190530170929.19366-1-jean-philippe.brucker@arm.com> From: Auger Eric Message-ID: <42408240-81a1-fe25-72da-5a93c9e1cb89@redhat.com> Date: Thu, 13 Jun 2019 17:54:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190530170929.19366-1-jean-philippe.brucker@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 13 Jun 2019 15:54:28 +0000 (UTC) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, On 5/30/19 7:09 PM, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.12 [1]. > Since last version [2] we've worked on improving the specification, > which resulted in the following changes to the interface: > * Remove the EXEC flag. > * Add feature bit for the MMIO flag. > * Change domain_bits to domain_range. > > Given that there were small changes to patch 5/7, I removed the review > and test tags. Please find the code at [3]. > > [1] Virtio-iommu specification v0.12, sources and pdf > git://linux-arm.org/virtio-iommu.git virtio-iommu/v0.12 > http://jpbrucker.net/virtio-iommu/spec/v0.12/virtio-iommu-v0.12.pdf > http://jpbrucker.net/virtio-iommu/spec/diffs/virtio-iommu-dev-diff-v0.11-v0.12.pdf > > [2] [PATCH v7 0/7] Add virtio-iommu driver > https://lore.kernel.org/linux-pci/0ba215f5-e856-bf31-8dd9-a85710714a7a@arm.com/T/ > > [3] git://linux-arm.org/linux-jpb.git virtio-iommu/v0.12 > git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.12 SERIES Tested-by: Eric Auger with QEMU branch: https://github.com/eauger/qemu/tree/v4.0-virtio-iommu-v0.12 and kernel branch: https://github.com/eauger/linux/tree/virtio-iommu-v0.12 (where I just added the rebased iort patches on top of Jean-Philippe's virtio-iommu/v0.12 branch). So I also tested the ACPI boot. I will formally submit the QEMU series ASAP. Thanks Eric > > Jean-Philippe Brucker (7): > dt-bindings: virtio-mmio: Add IOMMU description > dt-bindings: virtio: Add virtio-pci-iommu node > of: Allow the iommu-map property to omit untranslated devices > PCI: OF: Initialize dev->fwnode appropriately > iommu: Add virtio-iommu driver > iommu/virtio: Add probe request > iommu/virtio: Add event queue > > .../devicetree/bindings/virtio/iommu.txt | 66 + > .../devicetree/bindings/virtio/mmio.txt | 30 + > MAINTAINERS | 7 + > drivers/iommu/Kconfig | 11 + > drivers/iommu/Makefile | 1 + > drivers/iommu/virtio-iommu.c | 1176 +++++++++++++++++ > drivers/of/base.c | 10 +- > drivers/pci/of.c | 6 + > include/uapi/linux/virtio_ids.h | 1 + > include/uapi/linux/virtio_iommu.h | 165 +++ > 10 files changed, 1470 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt > create mode 100644 drivers/iommu/virtio-iommu.c > create mode 100644 include/uapi/linux/virtio_iommu.h >