archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <>
To: Linux PCI <>,
	Linux ACPI <>
Cc: LKML <>,
	Bjorn Helgaas <>,
	Mika Westerberg <>,
	David Box <>
Subject: [PATCH] PCI: ACPI: PM: Fix debug message in acpi_pci_set_power_state()
Date: Thu, 25 Mar 2021 19:57:51 +0100	[thread overview]
Message-ID: <4319486.LvFx2qVVIh@kreacher> (raw)

From: Rafael J. Wysocki <>

If PCI_D3cold is passed to acpi_pci_set_power_state() as the second
argument and there is no ACPI D3cold support for the given device,
the debug message printed by that function will state that the
device power state has been changed to D3cold, while in fact it
will be D3hot, because acpi_device_set_power() falls back to D3hot
automatically if D3cold is not supported without returning an error.

To address this issue, modify the debug message in question to print
the current power state of the target PCI device's ACPI companion
instead of printing the target power state which may not reflect
the real final power state of the device.

Signed-off-by: Rafael J. Wysocki <>
 drivers/pci/pci-acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/pci/pci-acpi.c
--- linux-pm.orig/drivers/pci/pci-acpi.c
+++ linux-pm/drivers/pci/pci-acpi.c
@@ -1021,7 +1021,7 @@ static int acpi_pci_set_power_state(stru
 	if (!error)
 		pci_dbg(dev, "power state changed by ACPI to %s\n",
-			 acpi_power_state_string(state_conv[state]));
+		        acpi_power_state_string(adev->power.state));
 	return error;

             reply	other threads:[~2021-03-25 18:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 18:57 Rafael J. Wysocki [this message]
2021-03-26  6:40 ` Krzysztof Wilczyński
2021-03-31 21:08 ` Bjorn Helgaas
2021-04-01 10:46   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4319486.LvFx2qVVIh@kreacher \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] PCI: ACPI: PM: Fix debug message in acpi_pci_set_power_state()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).