From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-16-git-send-email-wangyijing@huawei.com> <540994D4.6040500@cogentembedded.com> Mime-Version: 1.0 (1.0) In-Reply-To: <540994D4.6040500@cogentembedded.com> Content-Type: text/plain; charset=gb2312 Message-Id: <43412AE0-85BB-4B4B-A4EA-2C6D3B8B85D7@gmail.com> Cc: Yijing Wang , Bjorn Helgaas , Xinwei Hu , Wuyun , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "arnab.basu@freescale.com" , "Bharat.Bhushan@freescale.com" , "x86@kernel.org" , Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , "xen-devel@lists.xenproject.org" , Joerg Roedel , "iommu@lists.linux-foundation.org" , "linux-mips@linux-mips.org" , Benjamin Herrenschmidt , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , Sebastian Ott , Tony Luck , "linux-ia64@vger.kernel.org" , "David S. Miller" , "sparclinux@vger.kernel.org" , Chris Metcalf , Ralf Baechle From: wangyijing Subject: Re: [PATCH v1 15/21] Powerpc/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 5 Sep 2014 19:33:08 +0800 To: Sergei Shtylyov Sender: linux-arch-owner@vger.kernel.org List-ID: > 在 2014年9月5日，18:47，Sergei Shtylyov 写道： > > Hello. > >> On 9/5/2014 2:10 PM, Yijing Wang wrote: >> >> Use MSI chip framework instead of arch MSI functions to configure >> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > >> Signed-off-by: Yijing Wang >> --- >> arch/powerpc/kernel/msi.c | 14 ++++++++++++-- >> 1 files changed, 12 insertions(+), 2 deletions(-) > >> diff --git a/arch/powerpc/kernel/msi.c b/arch/powerpc/kernel/msi.c >> index 71bd161..01781a4 100644 >> --- a/arch/powerpc/kernel/msi.c >> +++ b/arch/powerpc/kernel/msi.c > [...] >> @@ -27,7 +27,17 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) >> return ppc_md.setup_msi_irqs(dev, nvec, type); >> } >> >> -void arch_teardown_msi_irqs(struct pci_dev *dev) >> +static void ppc_teardown_msi_irqs(struct pci_dev *dev) > > Shouldn't this function take IRQ # instead? This function need to teardown all msi irqs of the pci dev, we should pass the pci dev as argument . Thanks! Yijing. > >> { >> ppc_md.teardown_msi_irqs(dev); >> } >> + >> +static struct msi_chip ppc_msi_chip = { >> + .setup_irqs = ppc_setup_msi_irqs, >> + .teardown_irqs = ppc_teardown_msi_irqs, >> +}; >> + >> +struct msi_chip *arch_find_msi_chip(struct pci_dev *dev) >> +{ >> + return &ppc_msi_chip; >> +} > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html