From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pci-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:52292 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729721AbeGQQOe (ORCPT <rfc822;linux-pci@vger.kernel.org>);
        Tue, 17 Jul 2018 12:14:34 -0400
Subject: Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>, bhelgaas@google.com,
        keith.busch@intel.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
        shyam_iyer@dell.com, Frederick Lawler <fred@fredlawl.com>,
        Oza Pawandeep <poza@codeaurora.org>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20180717153135.25925-1-mr.nuke.me@gmail.com>
From: Sinan Kaya <okaya@kernel.org>
Message-ID: <494a5df8-0987-3a6c-30a4-a3c9ef4ed1f3@kernel.org>
Date: Tue, 17 Jul 2018 08:41:20 -0700
MIME-Version: 1.0
In-Reply-To: <20180717153135.25925-1-mr.nuke.me@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Sender: linux-pci-owner@vger.kernel.org
List-ID: <linux-pci.vger.kernel.org>


On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote:
> +	if (pcie_aer_get_firmware_first(dev))
> +		return -EIO;

Can you move this to closer to the caller pci_aer_init()?