From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "Florian Fainelli" <f.fainelli@gmail.com>,
"Krzysztof Wilczyński" <kw@linux.com>
Cc: nsaenz@kernel.org, jim2101024@gmail.com,
bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com,
robh@kernel.org, bhelgaas@google.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long'
Date: Mon, 8 Nov 2021 20:51:43 +0100 [thread overview]
Message-ID: <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> (raw)
In-Reply-To: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com>
Le 08/11/2021 à 17:28, Florian Fainelli a écrit :
>
>
> On 11/7/2021 5:34 PM, Krzysztof Wilczyński wrote:
>> Hi Christophe!
>>
>> [...]
>>> This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR
>>> long.
>>
>> Ahh. OK. Given this an option would be to: do nothing (keep current
>> status quo); allocate memory dynamically passing the "msi->nr" after it
>> has been set accordingly; use BRCM_INT_PCI_MSI_NR and waste a little bit
>> of space.
>>
>> Perhaps moving to using the DECLARE_BITMAP() would be fine in this case
>> too, at least to match style of other drivers more closely.
>>
>> Jim, Florian and Lorenzo - is this something that would be OK with you,
>> or you would rather keep things as they were?
>
> I would be tempted to leave the code as-is, but if we do we are probably
> bound to seeing patches like Christophe's in the future to address the
Even if I don't find this report in the Coverity database, it should
from around April 2018.
So, if you have not already received several patches for that, I doubt
that you will receive many in the future.
My own feeling is that using a long (and not a long *) as a bitmap, and
accessing it with &long may look spurious to a reader.
That said, it works.
So, I let you decide if the patch is of any use. Should I need to tweak
or resend it, let me know.
CJ
> problem, unless we place a coverity specific comment in the source tree,
> which is probably frowned upon.
>
> The addition of the BUILD_BUG_ON() is a good addition though.
next prev parent reply other threads:[~2021-11-08 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 8:32 [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Christophe JAILLET
2021-11-08 1:34 ` Krzysztof Wilczyński
2021-11-08 16:28 ` Florian Fainelli
2021-11-08 19:51 ` Christophe JAILLET [this message]
2021-11-08 23:30 ` Krzysztof Wilczyński
2021-11-08 23:45 ` Florian Fainelli
2021-11-08 23:55 ` Krzysztof Wilczyński
2021-11-08 23:44 ` Florian Fainelli
2021-11-29 13:11 ` Lorenzo Pieralisi
2021-11-30 17:04 ` Bjorn Helgaas
2021-12-03 11:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=jim2101024@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).