From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4C0C4332F for ; Thu, 23 Dec 2021 17:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349331AbhLWRCd (ORCPT ); Thu, 23 Dec 2021 12:02:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32519 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244308AbhLWRCc (ORCPT ); Thu, 23 Dec 2021 12:02:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640278952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0L3hrfGHh2CA7aMbkoiYJDWgrUzDP7juBauygQys1NE=; b=crVJQlN/JO2zqnvPxXEnCgKzsYPLHvinA3HORg+Ug2CoYnVjDDsPajUCq19cqGZ+DLEDSd y4EGgu8AC0AhSLlWZWTmCFH9mIkBdUH+nB/0q8Gsy1Wodvg8YUi8FBHxpSylaMBge8bbzk IxWJMJpm9sbHgcKp9qShuXHhTtf7Rxw= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-fiyNuuYyP1KFEf5p2wKISQ-1; Thu, 23 Dec 2021 12:02:31 -0500 X-MC-Unique: fiyNuuYyP1KFEf5p2wKISQ-1 Received: by mail-ed1-f70.google.com with SMTP id z8-20020a056402274800b003f8580bfb99so4945806edd.11 for ; Thu, 23 Dec 2021 09:02:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=0L3hrfGHh2CA7aMbkoiYJDWgrUzDP7juBauygQys1NE=; b=BtBONxEUKx/BlC8F3Fs0Cw5+YSV8pIVLFfd9ZTI+a9ZtPJgokAsGFWhdN/3XuRHOLK cKPeht2cQoQCzVRtc1HUo8r0SqW+S2zK36LKA+G9xqqprv37tEcusgcudqfWLZRbmw+l GlFQ+3VAHPKrXu1oqlwEpx4j2K6i3bbC+rlgd7a758mDzjPAt3RWMXxvlJSIDtpTCbNq jk/UFC4kXL2JWkupGkuB+6tG/U0w2JIlVh+fFI26taZf+G1f6pxX+kTH8K22gQh5JrpA xH2lUku8Pl3hESnpqp6aHhccqBIm/ptcEE1IFyW3ccUgGxxeT0HbcaNUIkd6NcSNk2EW CjDA== X-Gm-Message-State: AOAM533wbXyxKd6jVeEAQ1pK1nMSXPJl0I2/cz37RFH4Li9FONFAkybD MUHybPBw1bhcaGaFXLejm79UyZz/4p85k/6sAlOwb17MMhZFPgKXnOKPglSibHdZr8dbjjrBYtj K2Wn63B7zXLMTu8NAj6iW X-Received: by 2002:a17:906:f890:: with SMTP id lg16mr2710057ejb.757.1640278949776; Thu, 23 Dec 2021 09:02:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxd6UhL94vaLcT6InDaVEGyzk60r+sLqen2QhcGsQrIMo2bSgdjMPwZF4AcdCPefw/JLHpfew== X-Received: by 2002:a17:906:f890:: with SMTP id lg16mr2710037ejb.757.1640278949597; Thu, 23 Dec 2021 09:02:29 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id nc14sm1937751ejc.44.2021.12.23.09.02.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Dec 2021 09:02:29 -0800 (PST) Message-ID: <4f3eca9f-1d55-35f5-585d-d121b1c83920@redhat.com> Date: Thu, 23 Dec 2021 18:02:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v3 0/8] platform/x86: introduce p2sb_bar() helper Content-Language: en-US From: Hans de Goede To: Andy Shevchenko , Wolfram Sang , Jean Delvare , Heiner Kallweit , Lee Jones , Tan Jui Nee , Bjorn Helgaas , Mika Westerberg , Kate Hsuan , Jonathan Yong , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Jean Delvare , Peter Tyser , Andy Shevchenko , Linus Walleij , Mark Gross , Henning Schild References: <20211221181526.53798-1-andriy.shevchenko@linux.intel.com> <08236e18-f1ae-303c-3d2e-96f795d96c1f@redhat.com> In-Reply-To: <08236e18-f1ae-303c-3d2e-96f795d96c1f@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, On 12/23/21 18:00, Hans de Goede wrote: > Hi, > > On 12/21/21 19:15, Andy Shevchenko wrote: >> There are a few users and at least one more is coming that would >> like to utilize P2SB mechanism of hiding and unhiding a device from >> the PCI configuration space. >> >> Here is the series to deduplicate existing users and provide >> a generic way for new comers. >> >> It also includes a patch to enable GPIO controllers on Apollo Lake >> when it's used with ABL bootloader w/o ACPI support. >> >> The patch that bring the helper ("platform/x86/intel: Add Primary >> to Sideband (P2SB) bridge support") has a commit message that >> sheds a light on what the P2SB is and why this is needed. >> >> Please, comment on the approach and individual patches. >> >> The changes made in v2 do not change the main idea and the functionality >> in a big scale. What we need is probably one more (RE-)test done by Henning. >> I hope to have it merged to v5.17-rc1 that Siemens can develop their changes >> based on this series. >> >> I have tested this on Apollo Lake platform (I'm able to see SPI NOR and >> since we have an ACPI device for GPIO I do not see any attempts to recreate >> one). >> >> (Since it's cross subsystem, the PDx86 seems the main one and >> I think it makes sense to route it throught it with immutable >> tag or branch provided for the others). > > The series looks good to me: > > Acked-by: Hans de Goede > > For the series. > > Not sure if this is really 5.17 material this late in the cycle though, > but lets wait and see what Bjorn and Lee have to say (patch 8/8 still > needs an ack from Lee). Correction I just realized that that would be 7/8 that needs an ack from Lee and that 8/8 needs an ack from Wolfram. > I'm fine with taking this upstream through the pdx86 tree, please > prepare a pull-req for everyone involved with an immutable branch > pushed to pdx86/platform-drivers-x86.git/ > based on 5.16-rc1 (if everyone is happy with merging this for 5.17) or > based on 5.17-rc1 once that is out. Regards, Hans