From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:54247 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964784Ab2HPPSZ (ORCPT ); Thu, 16 Aug 2012 11:18:25 -0400 Message-ID: <502D0F3C.4010308@wwwdotorg.org> Date: Thu, 16 Aug 2012 09:18:20 -0600 From: Stephen Warren MIME-Version: 1.0 To: Thierry Reding CC: Bjorn Helgaas , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, Grant Likely , Rob Herring , devicetree-discuss@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Colin Cross , Olof Johansson , Mitch Bradley , Arnd Bergmann Subject: Re: [PATCH v3 05/10] resource: add PCI configuration space support References: <1343332512-28762-1-git-send-email-thierry.reding@avionic-design.de> <1343332512-28762-6-git-send-email-thierry.reding@avionic-design.de> <20120814055542.GB16181@avionic-0098.mockup.avionic-design.de> <20120814180142.GA9430@avionic-0098.mockup.avionic-design.de> <20120815064902.GB15665@avionic-0098.mockup.avionic-design.de> In-Reply-To: <20120815064902.GB15665@avionic-0098.mockup.avionic-design.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On 08/15/2012 12:49 AM, Thierry Reding wrote: ... > Stephen: Could you try to find out whether the regular > configuration space translation can just be omitted if we already > set up the one for the extended configuration space? In > tegra_pcie_setup_translations(), BAR 0 is setup for regular > configuration space (which requires a 16 MiB region), while BAR 1 > is setup for the extended configuration space (requiring a full 256 > MiB region). However, if I understand correctly, each of the > registers that can be accessed via the BAR 0 translation can also > be accessed via the BAR 1 translation. That seems like we're > wasting the 16 MiB set aside for the BAR 0 mapping. I have confirmed that in theory, the EXTCFG space can indeed be used to access any register, making the regular config space redundant. However, using the HW this way has apparently received less validation.