From: Yijing Wang <wangyijing@huawei.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Chen Gong <gong.chen@linux.intel.com>, <jiang.liu@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] PCI/AER: fix a small race condition window when rmmod aer_inject
Date: Thu, 13 Sep 2012 18:59:20 +0800 [thread overview]
Message-ID: <5051BC88.7040804@huawei.com> (raw)
In-Reply-To: <1347499761.30040.138.camel@yhuang-dev>
On 2012/9/13 9:29, Huang Ying wrote:
> On Wed, 2012-09-12 at 20:33 +0800, Yijing Wang wrote:
>> Fix a small race condition window between pci_bus_ops_pop() and
>> pci_bus_set_ops() functions.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>> ---
>> drivers/pci/pcie/aer/aer_inject.c | 8 ++------
>> 1 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
>> index bd043db..69c2d77 100644
>> --- a/drivers/pci/pcie/aer/aer_inject.c
>> +++ b/drivers/pci/pcie/aer/aer_inject.c
>> @@ -141,12 +141,11 @@ static struct pci_ops *__find_pci_bus_ops(struct pci_bus *bus)
>> return NULL;
>> }
>>
>> +/* inject_lock must be held before calling */
>> static struct pci_bus_ops *pci_bus_ops_pop(void)
>> {
>> - unsigned long flags;
>> struct pci_bus_ops *bus_ops = NULL;
>>
>> - spin_lock_irqsave(&inject_lock, flags);
>> if (list_empty(&pci_bus_ops_list))
>> bus_ops = NULL;
>> else {
>> @@ -154,7 +153,6 @@ static struct pci_bus_ops *pci_bus_ops_pop(void)
>> list_del(lh);
>> bus_ops = list_entry(lh, struct pci_bus_ops, list);
>> }
>> - spin_unlock_irqrestore(&inject_lock, flags);
>> return bus_ops;
>> }
>>
>> @@ -610,14 +608,12 @@ static void __exit aer_inject_exit(void)
>> bus_unregister_notifier(&pci_bus_type, &aerinj_hp_notifier);
>> misc_deregister(&aer_inject_device);
>>
>> + spin_lock_irqsave(&inject_lock, flags);
>> while ((bus_ops = pci_bus_ops_pop())) {
>> pci_bus_set_ops(bus_ops->bus, bus_ops->ops);
>> kfree(bus_ops);
>> }
>>
>> - clean_untracked_pci_aer_ops();
>> -
>> - spin_lock_irqsave(&inject_lock, flags);
>> list_for_each_entry_safe(err, err_next, &einjected, list) {
>> list_del(&err->list);
>> kfree(err);
>
> This may trigger a AB BA dead lock. In aer_inject_exit, the lock
> sequence is:
>
> inject_lock -> pci_lock
>
> In pci config read/write path, the lock sequence is:
>
> pci_lock -> inject_lock
>
> With lockdep enabled, you may found warning on that.
OK, I will carry out a detailed test with lockdep enabled, and try to improve this patch.
Thanks for review and comments!
------
Thanks
Yijing
>
> Best Regards,
> Huang YIng
>
>
>
> .
>
--
Thanks!
Yijing
prev parent reply other threads:[~2012-09-13 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 12:33 [PATCH v2 1/4] PCI/AER: Fix pci_ops return NULL when hotplug a pci bus doing aer error inject Yijing Wang
2012-09-12 12:33 ` [PATCH v2 2/4] PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject Yijing Wang
2012-09-13 1:43 ` Huang Ying
2012-09-13 10:54 ` Yijing Wang
2012-09-14 0:56 ` Huang Ying
2012-09-14 1:29 ` Yijing Wang
2012-09-12 12:33 ` [PATCH v2 3/4] PCI/AER: Clean pci_bus_ops when related pci bus was removed Yijing Wang
2012-09-12 12:33 ` [PATCH v2 4/4] PCI/AER: fix a small race condition window when rmmod aer_inject Yijing Wang
2012-09-13 1:29 ` Huang Ying
2012-09-13 10:59 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051BC88.7040804@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=gong.chen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).