From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Xiaofei Tan <tanxiaofei@huawei.com>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: Re: [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues
Date: Sat, 27 Mar 2021 06:39:07 -0700 [thread overview]
Message-ID: <50e838ca74c56b9fd5cbbc2d7234829f0e0b4131.camel@perches.com> (raw)
In-Reply-To: <CAHp75Vd0hVqsfsZK=d1dz98Kbchqz-w4RqQQp6FwisxSGG5BzA@mail.gmail.com>
On Sat, 2021-03-27 at 10:19 +0200, Andy Shevchenko wrote:
> On Saturday, March 27, 2021, Xiaofei Tan <tanxiaofei@huawei.com> wrote:
>
> > Fix some coding style issues reported by checkpatch.pl, including
> > following types:
> >
> > WARNING: simple_strtol is obsolete, use kstrtol instead
>
>
> And one more thing, the above message is bogus. Read what the comments in
> the code says about use cases for simple_*() vs. kstrto*() ones.
>
> Joe?
This check and message is nearly 10 years old and was appropriate for
when it was implemented.
kernel.h currently has:
* Use these functions if and only if you cannot use kstrto<foo>, because
So the message could be changed to something like:
WARNING: simple_strtol should be used only when kstrtol can not be used.
next prev parent reply other threads:[~2021-03-27 13:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:46 [PATCH v2 00/15] acpi: fix some coding style issues Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 01/15] ACPI: APD: fix a block comment align issue Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 02/15] ACPI: processor: fix some coding style issues Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 03/15] ACPI: debug: " Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed Xiaofei Tan
2021-03-29 10:09 ` David Laight
2021-03-30 2:23 ` Xiaofei Tan
2021-03-30 7:31 ` Zhang Rui
2021-03-30 7:59 ` Zhang Rui
2021-03-30 8:14 ` David Laight
2021-03-30 17:00 ` Rafael J. Wysocki
2021-03-31 15:55 ` Zhang Rui
2021-03-31 16:14 ` David Laight
2021-03-31 17:22 ` Bjorn Helgaas
2021-04-01 8:59 ` David Laight
2021-04-01 13:49 ` Rafael J. Wysocki
2021-04-01 14:23 ` David Laight
2021-04-01 17:29 ` Rafael J. Wysocki
2021-03-27 7:46 ` [PATCH v2 05/15] ACPI: ipmi: remove useless return statement for void function Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues Xiaofei Tan
[not found] ` <CAHp75Vc+0hxLS_Ab7_VZfrG2jiQzvia9S=o+Gc+wg+vVk1Z39w@mail.gmail.com>
2021-03-27 9:55 ` Xiaofei Tan
[not found] ` <CAHp75Vd0hVqsfsZK=d1dz98Kbchqz-w4RqQQp6FwisxSGG5BzA@mail.gmail.com>
2021-03-27 9:58 ` Xiaofei Tan
2021-03-27 13:39 ` Joe Perches [this message]
2021-03-27 16:39 ` Andy Shevchenko
2021-03-27 7:46 ` [PATCH v2 07/15] ACPI: memhotplug: fix a coding style issue Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 08/15] ACPI: acpi_pad: " Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 09/15] ACPI: battery: fix some coding style issues Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 10/15] ACPI: button: " Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 11/15] ACPI: CPPC: " Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 12/15] ACPI: custom_method: fix a coding style issue Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 13/15] ACPI: PM: fix some coding style issues Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 14/15] ACPI: sysfs: " Xiaofei Tan
2021-03-27 7:46 ` [PATCH v2 15/15] ACPI: dock: " Xiaofei Tan
[not found] ` <CAHp75VcwuFYWRYfVPxbqa4TFGgqOhHc_soefmTAZcGGk3bLuhw@mail.gmail.com>
2021-03-27 10:00 ` [PATCH 00/15] acpi: " Xiaofei Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e838ca74c56b9fd5cbbc2d7234829f0e0b4131.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).