From: Yijing Wang <wangyijing@huawei.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH] PCI: Separate stop and remove devices in pciehp
Date: Wed, 24 Jul 2013 12:00:47 +0800 [thread overview]
Message-ID: <51EF516F.6010102@huawei.com> (raw)
In-Reply-To: <CAE9FiQUQirapRONeb1ndOoKsiYviyXJVx3wZTcgzJj7bHX-1xQ@mail.gmail.com>
Hi Yinghai,
The third patch make pci_stop_dev call pci_disable_sriov(dev).
It looks asymmetrical, because pci_enable_sriov(dev, NR_VIRTFN) always
be called by device driver. Why not work around this in device driver like ixgbe?
I'm not familiar with SRIOV, so I'm just a bit puzzled.
Thanks!
Yijing.
------------------------------------------------------------
Some driver (like ixgbe) does not call pci_disable_sriov() if
sriov is enabled via /sys/.../sriov_numvfs setting.
ixgbe does allow driver for PF get detached, but still have VFs
around.
But how about PF get removed via /sys or pciehp finally?
During hot-remove, VF will still hold one ref to PF and it
prevent PF to be removed.
That make the next hot-add fails, as old PF dev struct is still around.
We need to add pci_disable_sriov() calling during stop PF .
Need this one for v3.11
-v2: Accoring to Bjorn, move that calling to pci_stop_dev.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Donald Dutile <ddutile@redhat.com>
Cc: Greg Rose <gregory.v.rose@intel.com>
---
drivers/pci/remove.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6/drivers/pci/remove.c
===================================================================
--- linux-2.6.orig/drivers/pci/remove.c
+++ linux-2.6/drivers/pci/remove.c
@@ -25,6 +25,8 @@ static void pci_stop_dev(struct pci_dev
pci_proc_detach_device(dev);
pci_remove_sysfs_dev_files(dev);
device_del(&dev->dev);
+ /* remove VF, if PF driver skip that */
+ pci_disable_sriov(dev);
dev->is_added = 0;
}
next prev parent reply other threads:[~2013-07-24 4:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 19:14 [PATCH] PCI: Fix hotplug remove with sriov again Yinghai Lu
2013-07-19 19:14 ` [PATCH] PCI: Separate stop and remove devices in pciehp Yinghai Lu
2013-07-22 21:23 ` Bjorn Helgaas
2013-07-23 2:32 ` Yinghai Lu
2013-07-23 15:56 ` Bjorn Helgaas
2013-07-23 22:44 ` Yinghai Lu
2013-07-23 23:15 ` Yinghai Lu
2013-07-24 4:00 ` Yijing Wang [this message]
2013-07-26 22:05 ` Bjorn Helgaas
2013-07-27 14:30 ` Yinghai Lu
2013-07-19 19:14 ` [PATCH] PCI: Stop sriov before remove PF Yinghai Lu
2013-07-19 21:46 ` Alexander Duyck
2013-07-19 22:44 ` Yinghai Lu
2013-07-19 23:22 ` Alexander Duyck
2013-07-23 15:34 ` Don Dutile
2013-07-23 16:10 ` Yinghai Lu
2013-07-22 23:15 ` Bjorn Helgaas
2013-07-23 1:59 ` Yinghai Lu
2013-07-22 7:07 ` [PATCH] PCI: Fix hotplug remove with sriov again Yijing Wang
2013-07-22 17:39 ` Bjorn Helgaas
2013-07-22 17:48 ` Yinghai Lu
2013-07-23 17:40 ` Bjorn Helgaas
2013-07-24 2:01 ` Yijing Wang
2013-07-24 2:04 ` Yinghai Lu
2013-07-24 2:15 ` Yinghai Lu
2013-07-24 2:25 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EF516F.6010102@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).