From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5406BFFF.9000505@huawei.com> Date: Wed, 3 Sep 2014 15:15:11 +0800 From: Yijing Wang MIME-Version: 1.0 To: "Bharat.Bhushan@freescale.com" , "arnab.basu@freescale.com" CC: Xinwei Hu , Wuyun , "Bjorn Helgaas" , "linux-pci@vger.kernel.org" , "Paul.Mundt@huawei.com" , "James E.J. Bottomley" , Marc Zyngier , "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-arch@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Hanjun Guo , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device References: <1406344128-27055-1-git-send-email-wangyijing@huawei.com> <53DEF80C.1010608@huawei.com> <8a2b4e237f2d4c7e95ef72867658b53a@BLUPR03MB566.namprd03.prod.outlook.com> <53F44022.6030706@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-arch-owner@vger.kernel.org List-ID: >> Provide the private MSI setup functions in bus-driver layer can't apply to all >> Non-PCI MSI devices, because we can not guarantee Non-PCI MSI devices are always >> on a bus. The existing HPET, DMAR device both have no bus bind. > > Yes, that's why I was not sure of bus-driver or device-driver model. > >> I'm working on a >> new MSI setup framework, as you mentioned before, in device-driver model. >> >> I abstracted a new virtual device (called struct msi_dev), this msi_dev will >> manage all MSI info, > > Will this "struct msi_dev" will be part of "struct device"? > >> and a new bus named msi_bus, also introduced a new driver >> msi_driver, msi_bus is responsible for binding msi_dev and msi_driver. >> All MSI devices will be classified into different MSI device types, like >> MSI_TYPE_PCI, MSI_TYPE_HPET, MSI_TYPE_DMAR, etc.. >> >> Each MSI type device should provide a private struct msi_driver. msi_driver >> should contain the type specific MSI ops functions to help setup and enable MSI >> device, request MSI irq. >> >> I almost finish the first draft, and will post out next week in plan :) > > Will be looking forward to next version. Hi Bharat, I'm sorry I had to delay to send out the new version :(. I found some risks in the new MSI framework, i.e. DMAR MSI initialized the MSI before the linux device-driver tree be built. And we also found some problems during test. So I think I need more time to review and test. Thanks! Yijing. > > Thanks > -Bharat > >> >> >> Thanks! >> Yijing. >> >>> >>> Thanks >>> -Bharat >>> >>>> >>>> My patchset is just a RFC draft, I will update it later, all we want >>>> to do is make kernel support Non-PCI MSI devices. >>>> >>>> Thanks! >>>> Yijing. >>>> >>>> >>>>> >>>>> Thanks >>>>> Arnab >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe >>>>> linux-kernel" in the body of a message to majordomo@vger.kernel.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>>> Please read the FAQ at http://www.tux.org/lkml/ >>>>> >>>>> . >>>>> >>>> >>>> >>>> -- >>>> Thanks! >>>> Yijing >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-pci" >>>> in the body of a message to majordomo@vger.kernel.org More majordomo >>>> info at http://vger.kernel.org/majordomo-info.html >>> >>> . >>> >> >> >> -- >> Thanks! >> Yijing >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body >> of a message to majordomo@vger.kernel.org More majordomo info at >> http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > . > -- Thanks! Yijing