From: Zhou Wang <wangzhou1@hisilicon.com>
To: Zou Wei <zou_wei@huawei.com>, <lorenzo.pieralisi@arm.com>,
<amurray@thegoodpenguin.co.uk>, <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static
Date: Thu, 23 Apr 2020 14:14:17 +0800 [thread overview]
Message-ID: <5EA13239.5070908@hisilicon.com> (raw)
In-Reply-To: <1587611883-26960-1-git-send-email-zou_wei@huawei.com>
On 2020/4/23 11:18, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks,
Zhou
> ---
> drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
> return 0;
> }
>
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> .bus_shift = 20,
> .init = hisi_pcie_platform_init,
> .pci_ops = {
>
next prev parent reply other threads:[~2020-04-23 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 3:18 [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
2020-04-23 6:14 ` Zhou Wang [this message]
2020-05-05 10:06 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EA13239.5070908@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).