From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: ryder.lee@mediatek.com, jianjun.wang@mediatek.com,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, p.zabel@pengutronix.de,
matthias.bgg@gmail.com, linux-pci@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com,
nfraprado@collabora.com
Subject: Re: [PATCH] PCI: mediatek-gen3: Assert resets to ensure expected init state
Date: Tue, 10 May 2022 09:59:22 +0200 [thread overview]
Message-ID: <5f61f655-e5bc-9e70-ce11-431b630a5331@collabora.com> (raw)
In-Reply-To: <20220509171631.GA605998@bhelgaas>
Il 09/05/22 19:16, Bjorn Helgaas ha scritto:
> On Mon, May 09, 2022 at 02:18:34PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 04/04/22 16:48, AngeloGioacchino Del Regno ha scritto:
>>> The controller may have been left out of reset by the bootloader,
>>> in which case, before the powerup sequence, the controller will be
>>> found preconfigured with values that were set before booting the
>>> kernel: this produces a controller failure, with the result of
>>> a failure during the mtk_pcie_startup_port() sequence as the PCIe
>>> link never gets up.
>>>
>>> To ensure that we get a clean start in an expected state, assert
>>> both the PHY and MAC resets before executing the controller
>>> power-up sequence.
>>>
>>> Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> Friendly ping for an important fix :-)
>
> d3bf75b579b9 appeared in v5.13-rc1 (May 2021, a year ago), so I assume
> this is important for v5.19, but not urgent enough to require being in
> v5.18. Right?
>
Hello Bjorn,
no it's not *very* urgent, as MediaTek devices that do require this will be
in v5.19 anyway...
Thanks,
Angelo
next prev parent reply other threads:[~2022-05-10 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 14:48 [PATCH] PCI: mediatek-gen3: Assert resets to ensure expected init state AngeloGioacchino Del Regno
2022-05-09 12:18 ` AngeloGioacchino Del Regno
2022-05-09 17:16 ` Bjorn Helgaas
2022-05-10 7:59 ` AngeloGioacchino Del Regno [this message]
2022-05-11 14:26 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f61f655-e5bc-9e70-ce11-431b630a5331@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=kernel@collabora.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).