From: Hanjie Lin <hanjie.lin@amlogic.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
shawn.lin@rock-chips.com, linux-kernel@vger.kernel.org,
Yue Wang <yue.wang@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe Phy controller
Date: Thu, 16 Aug 2018 11:01:26 +0800 [thread overview]
Message-ID: <60f152b4-39b3-0205-794b-13a1617956d8@amlogic.com> (raw)
In-Reply-To: <20180814225012.GA19305@rob-hp-laptop>
On 2018/8/15 6:50, Rob Herring wrote:
> On Tue, Aug 14, 2018 at 02:12:13AM -0400, Hanjie Lin wrote:
>> From: Yue Wang <yue.wang@amlogic.com>
>
> Subject should be "dt-bindings: phy: ..."
>
>> The Meson-PCIE-PHY controller supports the 5-Gbps data rate
>> of the PCI Express Gen 2 specification and is backwardcompatible
>
> space
yes, I will fix
^
>
>> with the 2.5-Gbps Gen 1.1 specification with only
>> inferred idle detection supported on AMLOGIC SoCs.
>
> AMLOGIC or Amlogic?
>
yes, we will stick to 'Amlogic'
>>
>> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com>
>> Signed-off-by: Yue Wang <yue.wang@amlogic.com>
>> ---
>> .../bindings/phy/amlogic,meson-pcie-phy.txt | 31 ++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-pcie-phy.txt
>>
>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-pcie-phy.txt b/Documentation/devicetree/bindings/phy/amlogic,meson-pcie-phy.txt
>> new file mode 100644
>> index 0000000..db99085
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-pcie-phy.txt
>> @@ -0,0 +1,31 @@
>> +* Amlogic Meson AXG PCIE PHY binding
>> +
>> +Required properties:
>> +- compatible: Should be
>> + - "amlogic,axg-pcie-phy"
>> +- #phys-cells: must be 0 (see phy-bindings.txt in this directory)
>
> You don't need to distinguish port A and B?
No, we don't. Theoretically there is only one phy in the chip,
and we have distinguished ports by reset lines.
Thanks for all corrections and suggestions.
>
>> +- reg: The base address and length of the registers
>> +- resets: phandle to the reset lines
>> +- reset-names: must contain "phy" and "peripheral"
>> + - "port_a" Port A reset
>> + - "port_b" Port B reset
>> + - "phy" PHY reset
>> + - "apb" APB reset
>> +Optional properties:
>> +- phy-supply: see phy-bindings.txt in this directory
>> +
>> +Example:
>> + pcie_phy: pcie-phy@ff644000 {
>> + #phy-cells = <0>;
>> + compatible = "amlogic,axg-pcie-phy";
>> + reg = <0x0 0xff644000 0x0 0x2000>;
>> + resets = <&reset RESET_PCIE_A>,
>> + <&reset RESET_PCIE_B>,
>> + <&reset RESET_PCIE_PHY>,
>> + <&reset RESET_PCIE_APB>;
>> + reset-names =
>> + "port_a",
>> + "port_b",
>> + "phy",
>> + "apb";
>> + };
>> --
>> 2.7.4
>>
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-08-16 3:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 6:12 [PATCH 0/2] add the Amlogic Meson PCIe phy driver Hanjie Lin
2018-08-14 6:12 ` [PATCH 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe Phy controller Hanjie Lin
2018-08-14 22:50 ` Rob Herring
2018-08-16 3:01 ` Hanjie Lin [this message]
2018-08-14 6:12 ` [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver Hanjie Lin
2018-08-14 10:41 ` Jerome Brunet
2018-08-16 3:05 ` Hanjie Lin
2018-08-16 8:33 ` Jerome Brunet
2018-08-17 6:12 ` Hanjie Lin
2018-08-17 8:09 ` Jerome Brunet
2018-08-17 11:17 ` Hanjie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f152b4-39b3-0205-794b-13a1617956d8@amlogic.com \
--to=hanjie.lin@amlogic.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).