From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3392C47082 for ; Sat, 5 Jun 2021 05:47:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88F1560FE7 for ; Sat, 5 Jun 2021 05:47:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbhFEFtM (ORCPT ); Sat, 5 Jun 2021 01:49:12 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:38771 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230233AbhFEFtM (ORCPT ); Sat, 5 Jun 2021 01:49:12 -0400 Received: from [192.168.0.3] (ip5f5aeece.dynamic.kabel-deutschland.de [95.90.238.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 0023361E64762; Sat, 5 Jun 2021 07:47:23 +0200 (CEST) Subject: Re: [Intel-wired-lan] [PATCH next-queue v4 1/4] Revert "PCI: Make pci_enable_ptm() private" To: Vinicius Costa Gomes , Bjorn Helgaas Cc: netdev@vger.kernel.org, richardcochran@gmail.com, hch@infradead.org, linux-pci@vger.kernel.org, bhelgaas@google.com, intel-wired-lan@lists.osuosl.org References: <20210604222542.GA2246166@bjorn-Precision-5520> <87bl8lxlbr.fsf@vcostago-mobl2.amr.corp.intel.com> From: Paul Menzel Message-ID: <61fbd916-ca4e-26b0-5d18-a2b2aa075a7f@molgen.mpg.de> Date: Sat, 5 Jun 2021 07:47:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87bl8lxlbr.fsf@vcostago-mobl2.amr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Dear Vinicius, dear Bjorn, Am 05.06.21 um 01:27 schrieb Vinicius Costa Gomes: > Bjorn Helgaas writes: > >> On Fri, Jun 04, 2021 at 03:09:30PM -0700, Vinicius Costa Gomes wrote: […] >>> Exposing this to the driver enables the driver to use the >>> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not. >>> >>> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c. >> >> Ideally I would cite this as ac6c26da29c1 ("PCI: Make pci_enable_ptm() >> private") so there's a little more context. > > Yeah, that looks better. > > Will follow the suggestions you made in the next patch as well and send > another version, thanks. Just a note, that this is how revert commits are generated by `git revert` as the name of the reverted commit is in the commit message summary. Maybe just move the statement/sentence to the very top? But either way is fine. Kind regards, Paul