From: Sinan Kaya <okaya@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
Yicong Yang <yangyicong@hisilicon.com>
Cc: linux-pci@vger.kernel.org, f.fangjian@huawei.com,
huangdaode@huawei.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Christoph Hellwig <hch@lst.de>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH 2/2] PCI/AER: Fix deadlock triggered by AER and sriov enable routine
Date: Wed, 1 Jul 2020 11:24:47 -0400 [thread overview]
Message-ID: <63f0a62c-ec47-e48f-d6b6-74448fef9de5@kernel.org> (raw)
In-Reply-To: <20200630235853.GA3500801@bjorn-Precision-5520>
On 6/30/2020 7:58 PM, Bjorn Helgaas wrote:
> when adding VF by sysfs:
> sriov_numvfs_store()
> device_lock()
> ...
> sriov_enable()
> ...
> pci_device_add()
> down_write(&pci_bus_sem)
> when invoking aer routine:
> pcie_do_recovery()
> ...
> pci_walk_bus()
> down_read(&pci_bus_sem)
> report_*()
> ...
> device_lock()
if we are going to this path, I'd like to see that we kill pci_bus_sem
altoghether.
next prev parent reply other threads:[~2020-07-01 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 9:18 [PATCH 2/2] PCI/AER: Fix deadlock triggered by AER and sriov enable routine Yicong Yang
2020-06-30 23:58 ` Bjorn Helgaas
2020-07-01 15:24 ` Sinan Kaya [this message]
2020-07-04 10:25 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f0a62c-ec47-e48f-d6b6-74448fef9de5@kernel.org \
--to=okaya@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=f.fangjian@huawei.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=huangdaode@huawei.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).