From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.130]:51745 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbaEGHjC (ORCPT ); Wed, 7 May 2014 03:39:02 -0400 From: Arnd Bergmann To: Bjorn Helgaas Cc: linux-doc@vger.kernel.org, Greg Kroah-Hartman , Joerg Roedel , Randy Dunlap , Liviu Dudau , linux-kernel@vger.kernel.org, James Bottomley , linux-pci@vger.kernel.org, David Woodhouse Subject: Re: [PATCH v2 2/5] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t Date: Wed, 07 May 2014 09:38 +0200 Message-ID: <6609032.iqZgu2KXQo@wuerfel> In-Reply-To: <20140506224826.17968.59068.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <20140506223250.17968.27054.stgit@bhelgaas-glaptop.roam.corp.google.com> <20140506224826.17968.59068.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org List-ID: On Tuesday 06 May 2014 16:48:26 Bjorn Helgaas wrote: > dma_declare_coherent_memory() takes two addresses for a region of memory: a > "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is > the physical address a *CPU* would use to access the region, and > "device_addr" is the bus address the *device* would use to address the > region. > > Rename "bus_addr" to "phys_addr" and change its type to phys_addr_t. > Most callers already supply a phys_addr_t for this argument. The others > supply a 32-bit integer (a constant, unsigned int, or __u32) and need no > change. > > Use "unsigned long", not phys_addr_t, to hold PFNs. > > Signed-off-by: Bjorn Helgaas > Acked-by: Arnd Bergmann