archive mirror
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <>
To: Bjorn Helgaas <>
Cc: "Lorenzo Pieralisi" <>,
	"Rob Herring" <>,
	"Krzysztof Wilczyński" <>,
	"Bjorn Helgaas" <>,
	"Pali Rohár" <>,
	"Masami Hiramatsu" <>,,,
Subject: Re: [PATCH] PCI: uniphier: Take lock in INTX irq_{mask,unmask,ack} callbacks
Date: Fri, 20 Aug 2021 08:03:02 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20210819112908.GA3188927@bjorn-Precision-5520>

Hi Bjorn,
Thank you for checking.

On 2021/08/19 20:29, Bjorn Helgaas wrote:
> Possibly update subject to be more descriptive, along lines of:
>    Serialize INTx masking/unmasking

Okay, I'll apply it to the subject.

> On Thu, Aug 19, 2021 at 07:56:06PM +0900, Kunihiko Hayashi wrote:
>> The same condition register PCI_RCV_INTX is used in irq_mask(),
>> irq_unmask() and irq_ack() callbacks. Accesses to register can occur at the
>> same time without lock.
>> This introduces a lock into the callbacks to prevent the issue.
> Rewrap into a single paragraph or add blank line between paragraphs.
> s/This introduces/Add/ to make this an imperative description of what
> you want this patch to do.  No need for "This" since the context is
> obvious.

I see. I'll rewrite the message to convey it more directly.

Thank you,

Best Regards
Kunihiko Hayashi

      reply	other threads:[~2021-08-19 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 10:56 [PATCH] PCI: uniphier: Take lock in INTX irq_{mask,unmask,ack} callbacks Kunihiko Hayashi
2021-08-19 11:29 ` Bjorn Helgaas
2021-08-19 23:03   ` Kunihiko Hayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).