From: Yuehaibing <yuehaibing@huawei.com>
To: <bhelgaas@google.com>, <sthemmin@microsoft.com>,
<sashal@kernel.org>, <decui@microsoft.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS
Date: Fri, 14 Jun 2019 22:19:10 +0800 [thread overview]
Message-ID: <6c97b2ae-b151-5610-d8d5-ef626d1f9bbb@huawei.com> (raw)
In-Reply-To: <20190531150923.12376-1-yuehaibing@huawei.com>
Hi all,
Friendly ping...
On 2019/5/31 23:09, YueHaibing wrote:
> while building without CONFIG_SYSFS, fails as below:
>
> drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_assign_slots':
> pci-hyperv.c:(.text+0x40a): undefined reference to 'pci_create_slot'
> drivers/pci/controller/pci-hyperv.o: In function 'pci_devices_present_work':
> pci-hyperv.c:(.text+0xc02): undefined reference to 'pci_destroy_slot'
> drivers/pci/controller/pci-hyperv.o: In function 'hv_pci_remove':
> pci-hyperv.c:(.text+0xe50): undefined reference to 'pci_destroy_slot'
> drivers/pci/controller/pci-hyperv.o: In function 'hv_eject_device_work':
> pci-hyperv.c:(.text+0x11f9): undefined reference to 'pci_destroy_slot'
>
> Select SYSFS while PCI_HYPERV is set to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 2ab9240..6722952 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -182,6 +182,7 @@ config PCI_LABEL
> config PCI_HYPERV
> tristate "Hyper-V PCI Frontend"
> depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && X86_64
> + select SYSFS
> help
> The PCI device frontend driver allows the kernel to import arbitrary
> PCI devices from a PCI backend to support PCI driver domains.
>
next prev parent reply other threads:[~2019-06-14 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 15:09 [PATCH] PCI: hv: Fix build error without CONFIG_SYSFS YueHaibing
2019-06-01 22:59 ` Michael Kelley
2019-06-15 6:18 ` Yuehaibing
2019-06-15 6:48 ` Yuehaibing
2019-08-13 10:18 ` Lorenzo Pieralisi
2019-08-13 12:43 ` Yuehaibing
2019-06-14 14:19 ` Yuehaibing [this message]
2019-06-14 15:23 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c97b2ae-b151-5610-d8d5-ef626d1f9bbb@huawei.com \
--to=yuehaibing@huawei.com \
--cc=bhelgaas@google.com \
--cc=decui@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).