From: Maximilian Luz <luzmaximilian@gmail.com>
To: Joe Perches <joe@perches.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: Remove trailing whitespace
Date: Wed, 4 Nov 2020 16:48:09 +0100 [thread overview]
Message-ID: <6d888eb0-bfc5-28ff-c62f-9e769f77bc1f@gmail.com> (raw)
In-Reply-To: <6e392d099bd8aaba14223aa770361dbdeeab271b.camel@perches.com>
On 11/4/20 6:13 AM, Joe Perches wrote:
[...]
>> Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
>> couple of them. I did not explicitly scan for other stuff like spaces
>> where there should be tabs, mostly because I haven't found a quick and
>> reliable solution for that. I only noticed an inconsistent indentation
>> when committing, so I fixed that too.
>
> You could try:
>
> $ git ls-files -- 'drivers/acpi/*.[ch]' | \
> xargs ./scripts/checkpatch.pl -f --fix-inplace --types=CODE_INDENT
Thanks, that indeed looks like a decent solution.
> Right now that produces:
> ---
[...]
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 46a64e9fa716..46be80976a03 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -89,7 +89,7 @@ struct acpi_ac {
> #define to_acpi_ac(x) power_supply_get_drvdata(x)
>
> /* --------------------------------------------------------------------------
> - AC Adapter Management
> + AC Adapter Management
> -------------------------------------------------------------------------- */
I'm not too sure about the comments, but I can find the time to look
over the output and adjust that if that's something you'd want me to do.
Regards,
Max
next prev parent reply other threads:[~2020-11-04 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 13:36 [PATCH] ACPI: Remove trailing whitespace Maximilian Luz
2020-11-03 21:12 ` Bjorn Helgaas
2020-11-03 21:30 ` Maximilian Luz
2020-11-04 5:13 ` Joe Perches
2020-11-04 15:48 ` Maximilian Luz [this message]
2020-11-04 17:12 ` Joe Perches
2020-11-04 17:20 ` Rafael J. Wysocki
2020-11-04 17:37 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d888eb0-bfc5-28ff-c62f-9e769f77bc1f@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).