From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C41C433E9 for ; Fri, 29 Jan 2021 03:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 887E564E07 for ; Fri, 29 Jan 2021 03:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231907AbhA2Duo (ORCPT ); Thu, 28 Jan 2021 22:50:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231861AbhA2Dug (ORCPT ); Thu, 28 Jan 2021 22:50:36 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18890C0613D6 for ; Thu, 28 Jan 2021 19:49:56 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id a25so8980770ljn.0 for ; Thu, 28 Jan 2021 19:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xMvJoMHuEXdWFwhVnHo1SQV4orUEAbd3SRkoCZWs3jQ=; b=CT2ivzq/AImbcMwRyug0dhVU6XpQ/KDjrVZcJ34Noi/PqsGK+I5u7bJv7mdhfy6eHs eFxrnCd5XyJisiZ/vrTzQUX8pM+TcDvW3UTi9L4SqdM0hTLNu9GSZINp2Ug9ChGVd2Gz NGNDRVGNYeFCUm7HRLNsZwzo5EWIWzmgIBjvhZCCqGd4wLtX+ZV/vtdnbYlXX5702Flb oJ30u05CYXRwhOTP0gi4yWMSjIPiWItLIS97IJhatJdelZvO+QeHTsyA41+QZ5UjCv/+ 9N3YCtS5QqHR99FOzFAfM3zbX3JNyS52Rr7UTTCmFzmN684SL12/vNWI8b/CamzL3LRr S5MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xMvJoMHuEXdWFwhVnHo1SQV4orUEAbd3SRkoCZWs3jQ=; b=Ai/hmcSgtVhFAZgF2Yez48+jnj/gmKpgjT4SG7xn6uzLxOS8FhRwPTMm8829/QHOF3 XOctqxw6YFcq2dGGnUbt399A0QzVeaUYpKKrmih7dafpchJBvHs4gejRjSFCzukfvykw ZENeBGjIA52jfk/ZJLE79/i1HYW1M7TdT+E15yVIc7SxrLYYquE5Cspid6ubjL5ZsFf9 jFbIONeR+h0IXtziAaIgBUYn1ZOaCDJiHAzWkc5gnOAyKSEMgB++R4iJu62cHENS3dp3 iqG1wh5pIruNqZVYqHXW7bQdEKfk55kzlgHPHD1CV9gHm6/m07WicdiWELq9DF6Y9HA+ dytg== X-Gm-Message-State: AOAM530InZuB9ls5fBd9eK/R62JaeV1jn9ud4rwie6wa5nIeCt3XEvwV 6oW0PPLnTk8oth8jIAxBE0NXquk07M4VwuHj X-Google-Smtp-Source: ABdhPJy5iwaV6zkENFUGsz+wmKhi/YZasjaeDKImIMv+I+rcV9HgjHv5ad5v55Gggc+I3ABQ67djow== X-Received: by 2002:a2e:5802:: with SMTP id m2mr1385650ljb.145.1611892194238; Thu, 28 Jan 2021 19:49:54 -0800 (PST) Received: from [192.168.1.211] ([94.25.229.83]) by smtp.gmail.com with ESMTPSA id s3sm2347641ljj.4.2021.01.28.19.49.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 19:49:53 -0800 (PST) Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: Add Bluetooth support on RB5 To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Arnd Bergmann , Greg Kroah-Hartman , Stanimir Varbanov , Lorenzo Pieralisi , Bjorn Helgaas , linux-arm-msm , Manivannan Sadhasivam , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , PCI References: <20210128175225.3102958-1-dmitry.baryshkov@linaro.org> <20210128175225.3102958-6-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov Message-ID: <6dd1f5cd-03c7-5945-9fa2-1c2698405110@linaro.org> Date: Fri, 29 Jan 2021 06:49:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 28/01/2021 22:15, Rob Herring wrote: > On Thu, Jan 28, 2021 at 11:52 AM Dmitry Baryshkov > wrote: >> >> From: Manivannan Sadhasivam >> >> Add Bluetooth support on RB5 using the onboard QCA6391 WLAN+BT chipset. >> >> Signed-off-by: Manivannan Sadhasivam >> [DB: added qca6391 power domain, removed s2f regulator] >> Signed-off-by: Dmitry Baryshkov >> --- >> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 29 ++++++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> index b39a9729395f..c65c13994a86 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> @@ -19,6 +19,7 @@ / { >> compatible = "qcom,qrb5165-rb5", "qcom,sm8250"; >> >> aliases { >> + hsuart0 = &uart6; > > Serial devices should be 'serialN'. Don't add custom aliases. Ack > >> serial0 = &uart12; >> sdhc2 = &sdhc_2; > > BTW, this should be dropped too. Ack > >> }; >> @@ -689,6 +690,26 @@ &pm8150_rtc { >> status = "okay"; >> }; >> >> +&qup_uart6_default { >> + ctsrx { >> + pins = "gpio16", "gpio19"; >> + drive-strength = <2>; >> + bias-disable; >> + }; >> + >> + rts { >> + pins = "gpio17"; >> + drive-strength = <2>; >> + bias-disable; >> + }; >> + >> + tx { >> + pins = "gpio18"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> @@ -1194,6 +1215,14 @@ wlan-en { >> }; >> }; >> >> +&uart6 { >> + status = "okay"; >> + bluetooth { >> + compatible = "qcom,qca6390-bt"; >> + power-domains = <&qca6391>; >> + }; >> +}; >> + >> &uart12 { >> status = "okay"; >> }; >> -- >> 2.29.2 >> -- With best wishes Dmitry