From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4F2C433E0 for ; Mon, 27 Jul 2020 16:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3134206E7 for ; Mon, 27 Jul 2020 16:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbgG0Q3C (ORCPT ); Mon, 27 Jul 2020 12:29:02 -0400 Received: from mga11.intel.com ([192.55.52.93]:22556 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgG0Q3C (ORCPT ); Mon, 27 Jul 2020 12:29:02 -0400 IronPort-SDR: hRjhxVLyBy6pZWxqOJBYEXNLDl/wpED3ZzAzqASKqm07x/YyjM0jtftafq6/2fSngXn39+/e4r cLV0hcS448BQ== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="148933484" X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="148933484" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2020 09:29:01 -0700 IronPort-SDR: bdMrx3VH1pOZBH7HrCMpWx80Ke4WrEZJaftJectfitABWJ9gyBX2X4331Xi2/SEzhR7+sM7RSp 9e1U4z1fyyAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="303521030" Received: from linux.intel.com ([10.54.29.200]) by orsmga002.jf.intel.com with ESMTP; 27 Jul 2020 09:29:00 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.7.201.137]) by linux.intel.com (Postfix) with ESMTP id CA232580677; Mon, 27 Jul 2020 09:29:00 -0700 (PDT) Message-ID: <718d3322c97561f69e156ed479e52d01d0899d78.camel@linux.intel.com> Subject: Re: [PATCH V4 0/3] Intel Platform Monitoring Technology From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: Andy Shevchenko , Lee Jones Cc: Darren Hart , Andy Shevchenko , Bjorn Helgaas , Alexander Duyck , Linux Kernel Mailing List , Platform Driver , linux-pci Date: Mon, 27 Jul 2020 09:29:00 -0700 In-Reply-To: References: <20200714062323.19990-1-david.e.box@linux.intel.com> <20200717190620.29821-1-david.e.box@linux.intel.com> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 2020-07-27 at 13:23 +0300, Andy Shevchenko wrote: > On Fri, Jul 17, 2020 at 10:05 PM David E. Box > wrote: > > Intel Platform Monitoring Technology (PMT) is an architecture for > > enumerating and accessing hardware monitoring capabilities on a > > device. > > With customers increasingly asking for hardware telemetry, > > engineers not > > only have to figure out how to measure and collect data, but also > > how to > > deliver it and make it discoverable. The latter may be through some > > device > > specific method requiring device specific tools to collect the > > data. This > > in turn requires customers to manage a suite of different tools in > > order to > > collect the differing assortment of monitoring data on their > > systems. Even > > when such information can be provided in kernel drivers, they may > > require > > constant maintenance to update register mappings as they change > > with > > firmware updates and new versions of hardware. PMT provides a > > solution for > > discovering and reading telemetry from a device through a hardware > > agnostic > > framework that allows for updates to systems without requiring > > patches to > > the kernel or software tools. > > > > PMT defines several capabilities to support collecting monitoring > > data from > > hardware. All are discoverable as separate instances of the PCIE > > Designated > > Vendor extended capability (DVSEC) with the Intel vendor code. The > > DVSEC ID > > field uniquely identifies the capability. Each DVSEC also provides > > a BAR > > offset to a header that defines capability-specific attributes, > > including > > GUID, feature type, offset and length, as well as configuration > > settings > > where applicable. The GUID uniquely identifies the register space > > of any > > monitor data exposed by the capability. The GUID is associated with > > an XML > > file from the vendor that describes the mapping of the register > > space along > > with properties of the monitor data. This allows vendors to perform > > firmware updates that can change the mapping (e.g. add new metrics) > > without > > requiring any changes to drivers or software tools. The new mapping > > is > > confirmed by an updated GUID, read from the hardware, which > > software uses > > with a new XML. > > > > The current capabilities defined by PMT are Telemetry, Watcher, and > > Crashlog. The Telemetry capability provides access to a continuous > > block > > of read only data. The Watcher capability provides access to > > hardware > > sampling and tracing features. Crashlog provides access to device > > crash > > dumps. While there is some relationship between capabilities > > (Watcher can > > be configured to sample from the Telemetry data set) each exists as > > stand > > alone features with no dependency on any other. The design > > therefore splits > > them into individual, capability specific drivers. MFD is used to > > create > > platform devices for each capability so that they may be managed by > > their > > own driver. The PMT architecture is (for the most part) agnostic to > > the > > type of device it can collect from. Devices nodes are consequently > > generic > > in naming, e.g. /dev/telem and /dev/smplr. Each capability > > driver > > creates a class to manage the list of devices supporting > > it. Software can > > determine which devices support a PMT feature by searching through > > each > > device node entry in the sysfs class folder. It can additionally > > determine > > if a particular device supports a PMT feature by checking for a PMT > > class > > folder in the device folder. > > > > This patch set provides support for the PMT framework, along with > > support > > for Telemetry on Tiger Lake. > > > > I assume this goes thru MFD tree. Yes, looking for pull by MFD. Thanks Andy.