linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Richard Zhu <hongxing.zhu@nxp.com>,
	p.zabel@pengutronix.de, bhelgaas@google.com,
	lorenzo.pieralisi@arm.com, robh@kernel.org, shawnguo@kernel.org,
	vkoul@kernel.org, alexander.stein@ew.tq-group.com
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-imx@nxp.com
Subject: Re: [PATCH v2 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support
Date: Thu, 14 Apr 2022 22:48:15 +0200	[thread overview]
Message-ID: <837af8d131bd0674d7466d89c3df74da08c8c435.camel@pengutronix.de> (raw)
In-Reply-To: <1646644054-24421-2-git-send-email-hongxing.zhu@nxp.com>

Am Montag, dem 07.03.2022 um 17:07 +0800 schrieb Richard Zhu:
> Add the i.MX8MP PCIe PHY PERST support.

As Philipp said: please add some more description on why this is
necessary. As far as I can see the reset is already present on 8MQ, and
is low-active, like this patch claims. We just didn't handle this reset
at all on other SoCs as the power on de-asserted state was okay to get
things working.

Regards,
Lucas

> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  drivers/reset/reset-imx7.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
> index 185a333df66c..d2408725eb2c 100644
> --- a/drivers/reset/reset-imx7.c
> +++ b/drivers/reset/reset-imx7.c
> @@ -329,6 +329,7 @@ static int imx8mp_reset_set(struct reset_controller_dev *rcdev,
>  		break;
>  
>  	case IMX8MP_RESET_PCIE_CTRL_APPS_EN:
> +	case IMX8MP_RESET_PCIEPHY_PERST:
>  		value = assert ? 0 : bit;
>  		break;
>  	}



  parent reply	other threads:[~2022-04-14 20:48 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07  9:07 [PATCH v2 0/7] Add the iMX8MP PCIe support Richard Zhu
2022-03-07  9:07 ` [PATCH v2 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
2022-04-04  9:34   ` Philipp Zabel
2022-04-15  7:32     ` Hongxing Zhu
2022-04-26  3:27       ` Hongxing Zhu
2022-04-14 20:48   ` Lucas Stach [this message]
2022-04-18  4:54     ` Hongxing Zhu
2022-03-07  9:07 ` [PATCH v2 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
2022-03-08  1:07   ` Rob Herring
2022-03-10  2:04     ` Hongxing Zhu
2022-03-07  9:07 ` [PATCH v2 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
2022-03-08 10:04   ` Lucas Stach
2022-03-09  6:05     ` Hongxing Zhu
2022-04-14 20:58   ` Lucas Stach
2022-04-18  4:55     ` Hongxing Zhu
2022-04-27 15:18       ` Lucas Stach
2022-04-28  1:29         ` Hongxing Zhu
2022-05-26  1:32           ` Hongxing Zhu
2022-03-07  9:07 ` [PATCH v2 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string Richard Zhu
2022-03-10 20:10   ` Rob Herring
2022-03-07  9:07 ` [PATCH v2 5/7] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
2022-04-14 21:02   ` Lucas Stach
2022-04-18  4:55     ` Hongxing Zhu
2022-05-23 18:47       ` Tim Harvey
2022-05-24  2:44         ` Hongxing Zhu
2022-03-07  9:07 ` [PATCH v2 6/7] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-03-24 10:04   ` (EXT) " Alexander Stein
2022-03-28  3:00     ` Hongxing Zhu
2022-04-14 21:04   ` Lucas Stach
2022-04-18  4:55     ` Hongxing Zhu
2022-03-07  9:07 ` [PATCH v2 7/7] PCI: imx6: Add the iMX8MP " Richard Zhu
2022-05-12 16:08   ` Lorenzo Pieralisi
2022-05-13  2:22     ` Hongxing Zhu
2022-03-09  7:57 ` (EXT) [PATCH v2 0/7] " Alexander Stein
2022-03-10  2:03   ` Hongxing Zhu
2022-04-07 20:41 ` Tim Harvey
2022-04-08  3:14   ` Hongxing Zhu
2022-04-08  8:12     ` Lucas Stach
2022-04-11  3:32       ` Hongxing Zhu
2022-04-13  7:21         ` Lucas Stach
2022-04-13  7:55           ` Hongxing Zhu
2022-04-11 22:18     ` Tim Harvey
2022-04-14 20:45 ` Lucas Stach
2022-04-18  4:54   ` Hongxing Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837af8d131bd0674d7466d89c3df74da08c8c435.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).