From: Marc Zyngier <maz@kernel.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] genirq/msi: Fix fwnode leak
Date: Thu, 26 Jan 2023 08:10:08 +0000 [thread overview]
Message-ID: <87a625emxr.wl-maz@kernel.org> (raw)
In-Reply-To: <167468839713.2297784.1309086853550595503.stgit@omen>
On Wed, 25 Jan 2023 23:13:48 +0000,
Alex Williamson <alex.williamson@redhat.com> wrote:
>
> kmemleak is reporting pairs of leaked buffers when PCI devices are
> unbound from their drivers. One of these buffers contains the name of
> the interrupt as generated for the msi_domain_template bundle in
> msi_create_device_irq_domain(). This name is passed through
> irq_domain_alloc_named_fwnode(), where an irqchip_rwid is allocated,
> along with a separate allocation via kasprintf() for another copy of
> the name. These are the two leaked buffers.
>
> Resolve this by adding the missing call to irq_domain_free_fwnode() in
> msi_remove_device_irq_domain().
>
> Fixes: 27a6dea3ebaa ("genirq/msi: Provide msi_create/free_device_irq_domain()")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Thomas has already queued this:
commit ac8f29aef2f1695956ff6773b33f975290437f29 (tip/irq/urgent)
Author: Jason Gunthorpe <jgg@ziepe.ca>
Date: Tue Jan 17 15:16:17 2023 -0400
genirq/msi: Free the fwnode created by msi_create_device_irq_domain()
which I assume will make it into Linus' tree shortly.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2023-01-26 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 23:13 [PATCH] genirq/msi: Fix fwnode leak Alex Williamson
2023-01-26 8:10 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a625emxr.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).