From: Marc Zyngier <maz@kernel.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: tglx@linutronix.de, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)
Date: Thu, 07 Oct 2021 09:52:50 +0100 [thread overview]
Message-ID: <87bl41qkrh.wl-maz@kernel.org> (raw)
In-Reply-To: <CALjTZvakX8Hz+ow3UeAuQiicVXtbkXEDFnHU-+n8Ts6i1LRyHQ@mail.gmail.com>
On Wed, 06 Oct 2021 12:06:55 +0100,
Rui Salvaterra <rsalvaterra@gmail.com> wrote:
>
> Hi, Marc,
>
> On Wed, 6 Oct 2021 at 12:00, Marc Zyngier <maz@kernel.org> wrote:
> >
> > Could you please give more context for this error? I assume that this
> > is some ATA device probing, but this is unclear at best. A full dmesg
> > definitely help.
>
> I'd love to have it, but I don't have a serial console to get it from.
> I can take a photo, of course, but there's no stack dump.
That wouldn't be very helpful, unfortunately.
>
> > 'lspci -vvnn' would also be useful to understand what the device wants
> > in terms of PCI configuration.
>
> Sure thing, here it goes (complete dump):
>
> 00:0b.0 SATA controller [0106]: NVIDIA Corporation MCP79 AHCI
> Controller [10de:0ab8] (rev b1) (prog-if 01 [AHCI 1.0])
> Subsystem: ZOTAC International (MCO) Ltd. MCP79 AHCI Controller [19da:a108]
> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx+
> Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Latency: 0 (750ns min, 250ns max)
> Interrupt: pin A routed to IRQ 30
> Region 0: I/O ports at d000 [size=8]
> Region 1: I/O ports at cc00 [size=4]
> Region 2: I/O ports at c880 [size=8]
> Region 3: I/O ports at c800 [size=4]
> Region 4: I/O ports at c480 [size=16]
> Region 5: Memory at fae76000 (32-bit, non-prefetchable) [size=8K]
> Capabilities: [44] Power Management version 2
> Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-)
> Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> Capabilities: [8c] SATA HBA v1.0 InCfgSpace
> Capabilities: [b0] MSI: Enable+ Count=1/8 Maskable- 64bit+
> Address: 00000000fee02004 Data: 0026
> Kernel driver in use: ahci
I guess this is the relevant device? It is interesting that it
advertises not supporting interrupt masking... Can you, you, out of
curiosity, give the following hack a go? I would expect things to
behave badly too (and maybe be even worse). But one way or another, it
may give us a hint.
Thanks,
M.
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0099a00af361..b3c0b9d07f17 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -205,7 +205,7 @@ static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
if (desc->msi_attrib.is_msix)
pci_msix_mask(desc);
- else if (desc->msi_attrib.maskbit)
+ else //if (desc->msi_attrib.maskbit)
pci_msi_mask(desc, mask);
}
@@ -216,7 +216,7 @@ static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
if (desc->msi_attrib.is_msix)
pci_msix_unmask(desc);
- else if (desc->msi_attrib.maskbit)
+ else //if (desc->msi_attrib.maskbit)
pci_msi_unmask(desc, mask);
}
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-10-07 8:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 8:50 [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79) Rui Salvaterra
2021-10-06 11:00 ` Marc Zyngier
2021-10-06 11:06 ` Rui Salvaterra
2021-10-07 8:52 ` Marc Zyngier [this message]
2021-10-07 12:03 ` Rui Salvaterra
2021-10-07 12:15 ` Marc Zyngier
2021-10-07 13:11 ` Rui Salvaterra
2021-10-07 14:42 ` Marc Zyngier
2021-10-07 14:50 ` Rui Salvaterra
2021-10-07 15:03 ` Marc Zyngier
2021-10-07 16:13 ` Rui Salvaterra
2021-10-06 11:44 ` Rui Salvaterra
2021-10-06 11:48 ` Rui Salvaterra
2021-10-11 18:47 ` Josef Johansson
2021-10-11 19:34 ` Josef Johansson
2021-10-12 5:37 ` Josef Johansson
2021-10-12 13:07 ` Jason Andryuk
2021-10-12 13:33 ` Josef Johansson
2021-10-12 15:17 ` Josef Johansson
2021-10-12 11:34 ` Marc Zyngier
2021-10-12 12:33 ` Josef Johansson
2021-10-31 22:51 ` Rui Salvaterra
2021-11-01 11:21 ` Marc Zyngier
2021-11-01 11:36 ` Rui Salvaterra
[not found] <1374495046.4164334.1635737050153@localhost>
2021-11-01 11:06 ` Rui Salvaterra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl41qkrh.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).