From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: intel-wired-lan@lists.osuosl.org, sasha.neftin@intel.com,
anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org,
bhelgaas@google.com, netdev@vger.kernel.org, mlichvar@redhat.com,
richardcochran@gmail.com, hch@infradead.org
Subject: Re: [PATCH next-queue v4 1/4] Revert "PCI: Make pci_enable_ptm() private"
Date: Fri, 04 Jun 2021 16:27:04 -0700 [thread overview]
Message-ID: <87bl8lxlbr.fsf@vcostago-mobl2.amr.corp.intel.com> (raw)
In-Reply-To: <20210604222542.GA2246166@bjorn-Precision-5520>
Bjorn Helgaas <helgaas@kernel.org> writes:
> On Fri, Jun 04, 2021 at 03:09:30PM -0700, Vinicius Costa Gomes wrote:
>> Make pci_enable_ptm() accessible from the drivers.
>>
>> Even if PTM still works on the platform I am using without calling
>> this function, it might be possible that it's not always the case.
>
> Not really relevant to this commit, strictly speaking.
>
Will remove then.
>> Exposing this to the driver enables the driver to use the
>> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.
>>
>> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.
>
> Ideally I would cite this as ac6c26da29c1 ("PCI: Make pci_enable_ptm()
> private") so there's a little more context.
>
Yeah, that looks better.
Will follow the suggestions you made in the next patch as well and send
another version, thanks.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2021-06-04 23:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 22:09 [PATCH next-queue v4 0/4] igc: Add support for PCIe PTM Vinicius Costa Gomes
2021-06-04 22:09 ` [PATCH next-queue v4 1/4] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2021-06-04 22:25 ` Bjorn Helgaas
2021-06-04 23:27 ` Vinicius Costa Gomes [this message]
2021-06-05 5:47 ` [Intel-wired-lan] " Paul Menzel
2021-06-04 22:09 ` [PATCH next-queue v4 2/4] PCI: Add pcie_ptm_enabled() Vinicius Costa Gomes
2021-06-04 22:27 ` Bjorn Helgaas
2021-06-04 22:09 ` [PATCH next-queue v4 3/4] igc: Enable PCIe PTM Vinicius Costa Gomes
2021-06-04 22:09 ` [PATCH next-queue v4 4/4] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl8lxlbr.fsf@vcostago-mobl2.amr.corp.intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).