From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF57C2D0DB for ; Fri, 31 Jan 2020 21:45:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98F2720707 for ; Fri, 31 Jan 2020 21:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbgAaVpp (ORCPT ); Fri, 31 Jan 2020 16:45:45 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:56684 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbgAaVpo (ORCPT ); Fri, 31 Jan 2020 16:45:44 -0500 Received: from 51.26-246-81.adsl-static.isp.belgacom.be ([81.246.26.51] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ixe6f-0005eR-6Z; Fri, 31 Jan 2020 22:45:41 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id BE110105BDC; Fri, 31 Jan 2020 22:45:35 +0100 (CET) From: Thomas Gleixner To: Evan Green Cc: Rajat Jain , Bjorn Helgaas , linux-pci , Linux Kernel Mailing List , x86@kernel.org, Marc Zyngier Subject: Re: [PATCH V2] x86/apic/msi: Plug non-maskable MSI affinity race In-Reply-To: References: <20200117162444.v2.1.I9c7e72144ef639cc135ea33ef332852a6b33730f@changeid> <87y2tytv5i.fsf@nanos.tec.linutronix.de> <87eevqkpgn.fsf@nanos.tec.linutronix.de> <87d0b82a9o.fsf@nanos.tec.linutronix.de> <878slwmpu9.fsf@nanos.tec.linutronix.de> <87imkv63yf.fsf@nanos.tec.linutronix.de> <87pnf342pr.fsf@nanos.tec.linutronix.de> <877e1a2d11.fsf@nanos.tec.linutronix.de> <874kwd3lbn.fsf@nanos.tec.linutronix.de> <87lfpn50id.fsf@nanos.tec.linutronix.de> <87imkr4s7n.fsf@nanos.tec.linutronix.de> Date: Fri, 31 Jan 2020 22:45:35 +0100 Message-ID: <87d0azuwow.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Evan Green writes: > On Fri, Jan 31, 2020 at 6:27 AM Thomas Gleixner wrote: >> #1 is uninteresting and has no unintended side effects. #2 and #3 might >> expose issues in device driver interrupt handlers which are not prepared to >> handle a spurious interrupt correctly. This not a regression, it's just >> exposing something which was already broken as spurious interrupts can >> happen for a lot of reasons and all driver handlers need to be able to deal >> with them. >> >> Reported-by: Evan Green >> Debugged-by: Evan Green Signed-off-by: Thomas Gleixner > > Heh, thanks for the credit. Thanks for the detective work and the persistance to convince me! > Something weird happened on this line with your signoff, though. Yeah. No idea how I fatfingered that. > I've been running this on my system for a few hours with no issues > (normal repro in <1 minute). So, > > Tested-by: Evan Green Thanks for confirmation! tglx