From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4669FC04FF3 for ; Fri, 21 May 2021 21:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21A39613C8 for ; Fri, 21 May 2021 21:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229472AbhEUVqk (ORCPT ); Fri, 21 May 2021 17:46:40 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:56566 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhEUVqj (ORCPT ); Fri, 21 May 2021 17:46:39 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1621633514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XaPyYtGVTJJud1M86TNOLs+rsQI2Kj9lnXY3H+cu/B0=; b=GWPNOh34mwS1P2HssdlKXWYC2cb0/7ReSUe88lhO6VM4W67K+8jaNdN8J1QWRZKOCLZLek obNhTVmcA5eECX4vLfE+2ewnqfM/obokPSvUsKqeHpp2FNJlJFkezOS+ankHC3USbbYBhO JxOmEOXlZgcrwxQx2MO2bpdr3TzCJ4gwjrOtRz4xqLIgIXC9EW4tufADmasY68QKks/eBk oHkXV0k9J2uwivI0KgsTFxkCMCQfVmuu6GRr9USMiKFNX0/uB2UqPIF+ycpUjf8Dw/DxRH vBzB05qF5vJ/LYbp39ehcGCxW3E1AgdJw9h8vZTc6eP8x5PGBx+YOCtWarNtVg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1621633514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XaPyYtGVTJJud1M86TNOLs+rsQI2Kj9lnXY3H+cu/B0=; b=ys1EeWOdNdNZ7QDxXGBp6GDvs0ZkBupG3nrlJ/lE35qgxunHJzjnNadxRQswz2zQMVaPrI 8Tsdrf+ncPocWqCA== To: Lijun Pan Cc: Nitesh Lal , Jesse Brandeburg , Robin Murphy , Marcelo Tosatti , Ingo Molnar , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, jbrandeb@kernel.org, "frederic\@kernel.org" , "juri.lelli\@redhat.com" , Alex Belits , "linux-api\@vger.kernel.org" , "bhelgaas\@google.com" , "linux-pci\@vger.kernel.org" , "rostedt\@goodmis.org" , "peterz\@infradead.org" , "davem\@davemloft.net" , "akpm\@linux-foundation.org" , "sfr\@canb.auug.org.au" , "stephen\@networkplumber.org" , "rppt\@linux.vnet.ibm.com" , "jinyuqi\@huawei.com" , "zhangshaokun\@hisilicon.com" , netdev@vger.kernel.org, chris.friesen@windriver.com, Marc Zyngier , Neil Horman , pjwaskiewicz@gmail.com Subject: Re: [PATCH] genirq: Provide new interfaces for affinity hints In-Reply-To: References: <20210504092340.00006c61@intel.com> <87pmxpdr32.ffs@nanos.tec.linutronix.de> <87im3gewlu.ffs@nanos.tec.linutronix.de> <87zgwo9u79.ffs@nanos.tec.linutronix.de> <87wnrs9tvp.ffs@nanos.tec.linutronix.de> Date: Fri, 21 May 2021 23:45:14 +0200 Message-ID: <87eedzahhx.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, May 21 2021 at 10:45, Lijun Pan wrote: > On Fri, May 21, 2021 at 7:48 AM Thomas Gleixner wrote: >> +/** >> + * irq_update_affinity_hint - Update the affinity hint >> + * @irq: Interrupt to update >> + * @cpumask: cpumask pointer (NULL to clear the hint) >> + * >> + * Updates the affinity hint, but does not change the affinity of the interrupt. >> + */ >> +static inline int >> +irq_update_affinity_hint(unsigned int irq, const struct cpumask *m) >> +{ >> + return __irq_apply_affinity_hint(irq, m, true); >> +} > > Should it be: > return __irq_apply_affinity_hint(irq, m, false); > here? Of course. Copy & Pasta should be forbidden. Thanks for spotting it! tglx