From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
intel-wired-lan@lists.osuosl.org, andre.guedes@intel.com,
linux-pci@vger.kernel.org, netdev@vger.kernel.org,
bhelgaas@google.com
Subject: Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()
Date: Wed, 18 Nov 2020 16:22:37 -0800 [thread overview]
Message-ID: <87wnyi2o1e.fsf@intel.com> (raw)
In-Reply-To: <20201118125451.GC23320@hoboy.vegasvil.org>
Hi Richard,
Richard Cochran <richardcochran@gmail.com> writes:
> On Tue, Nov 17, 2020 at 05:21:48PM -0800, Vinicius Costa Gomes wrote:
>> Agreed that would be easiest/simplest. But what I have in hand seems to
>> not like it, i.e. I have an earlier series implementing this "one shot" way
>> and it's not reliable over long periods of time or against having the
>> system time adjusted.
>
> Before we go inventing a new API, I think we should first understand
> why the one shot thing fails.
Talking with the hardware folks, they recommended using the periodic
method, the one shot method was implemented as a debug/evaluation aid.
The explanation I have is something along these lines: the hardware
keeps track of the "delta" between the Master Time and its own clock,
and uses it to calculate the timestamps exposed in the NIC registers. To
have a better "delta" it needs more samples. And so it has improved
stability when PTM dialogs happen more continuously, and that's the
recommended way.
The PCIe PTM specification doesn't suggest how the timestamps need to be
exposed/calculated, and how long it needs to run, and it sounded to me
that other implementations could have similar behavior.
>
> If there is problem with the system time being adjusted during PTM,
> then that needs solving in any case!
When PTM is running in the periodic mode, system clock adjustments are
handled fine.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2020-11-19 0:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 6:10 [PATCH next-queue v2 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes
2020-11-10 6:10 ` [PATCH next-queue v2 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2020-11-10 6:10 ` [PATCH next-queue v2 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes
2020-11-10 6:10 ` [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2020-11-10 18:07 ` [Intel-wired-lan] " Miroslav Lichvar
2020-11-10 19:06 ` Vinicius Costa Gomes
2020-11-11 9:33 ` Miroslav Lichvar
2020-11-11 22:23 ` Vinicius Costa Gomes
2020-11-12 9:32 ` Miroslav Lichvar
2020-11-12 23:46 ` Vinicius Costa Gomes
2020-11-13 3:24 ` Richard Cochran
2020-11-13 19:10 ` Vinicius Costa Gomes
2020-11-14 2:57 ` Richard Cochran
2020-11-17 1:06 ` Vinicius Costa Gomes
2020-11-17 1:49 ` Richard Cochran
2020-11-18 1:21 ` Vinicius Costa Gomes
2020-11-18 12:54 ` Richard Cochran
2020-11-19 0:22 ` Vinicius Costa Gomes [this message]
2020-11-20 14:16 ` Richard Cochran
2020-11-20 17:58 ` Vinicius Costa Gomes
2021-03-22 15:36 ` Vinicius Costa Gomes
2021-03-23 4:17 ` Richard Cochran
2020-11-18 15:55 ` Jakub Kicinski
2020-11-20 19:07 ` Vinicius Costa Gomes
2020-11-12 0:38 ` Vinicius Costa Gomes
2021-03-22 15:47 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnyi2o1e.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=andre.guedes@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).