From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7826C433B4 for ; Mon, 17 May 2021 19:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95C9D6134F for ; Mon, 17 May 2021 19:47:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235232AbhEQTsd (ORCPT ); Mon, 17 May 2021 15:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235119AbhEQTsc (ORCPT ); Mon, 17 May 2021 15:48:32 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C52D2C061573; Mon, 17 May 2021 12:47:15 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1621280833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PpozXE9Eg8reNXM2Sd0imFqDURR7dGqzmLBtJPdjcXE=; b=WT4bXOeoC+ZgH20z5dJSPmzeEJizXclBOtClrdp4waF8XiJ9eYKKO5ZVSjO8HKNDaJbHjJ /GamRxcZTVMMTAms7SqJ+UGZ47Dy8vjlNjJaiycBChJ4rUZBTSYim17/iPesXu5KwJVj4E G/e7XtdXD0HRyELDnIdr0iy/Ncen4MzYCCgHLcJeGusokoXbQnni2QFIz6UwCVcBh9dpCE 3sraYiKeMQERVsEnhLvAEVsQpsw3l9H2O1YT2po81RmZzrFPBVEEGvYaQBrOpONU5S3qB4 ybNFo1I235w7fAAh0/sXOlMH5G6zncY6opF8A5dUrRdayHcgVd0+GmZzbdhyYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1621280833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PpozXE9Eg8reNXM2Sd0imFqDURR7dGqzmLBtJPdjcXE=; b=4GxHSpNZswHYqUYSoeQLyu68tGD1lxN1swfD+vqX8hilV/B9yRXxT8SOH0B7kuSEayiXCI AQwV0hZYJX2NtIDg== To: Nitesh Lal , Robin Murphy Cc: Jesse Brandeburg , "frederic\@kernel.org" , "juri.lelli\@redhat.com" , Marcelo Tosatti , Ingo Molnar , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, jbrandeb@kernel.org, Alex Belits , "linux-api\@vger.kernel.org" , "bhelgaas\@google.com" , "linux-pci\@vger.kernel.org" , "rostedt\@goodmis.org" , "peterz\@infradead.org" , "davem\@davemloft.net" , "akpm\@linux-foundation.org" , "sfr\@canb.auug.org.au" , "stephen\@networkplumber.org" , "rppt\@linux.vnet.ibm.com" , "jinyuqi\@huawei.com" , "zhangshaokun\@hisilicon.com" , netdev@vger.kernel.org, chris.friesen@windriver.com, Marc Zyngier Subject: Re: [PATCH tip:irq/core v1] genirq: remove auto-set of the mask when setting the hint In-Reply-To: References: <20210501021832.743094-1-jesse.brandeburg@intel.com> <16d8ca67-30c6-bb4b-8946-79de8629156e@arm.com> <20210504092340.00006c61@intel.com> Date: Mon, 17 May 2021 21:47:12 +0200 Message-ID: <87y2cddtxb.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Nitesh, On Mon, May 17 2021 at 14:21, Nitesh Lal wrote: > On Mon, May 17, 2021 at 1:26 PM Robin Murphy wrote: > > We can use irq_set_affinity() to set the hint mask as well, however, maybe > there is a specific reason behind separating those two in the > first place (maybe not?). Yes, because kernel side settings might overwrite the hint. > But even in this case, we have to either modify the PMU drivers' IRQs > affinity from the userspace or we will have to make changes in the existing > request_irq code path. Adjusting them from user space does not work for various reasons, especially CPU hotplug. > I am not sure about the latter because we already have the required controls > to adjust the device IRQ mask (by using default_smp_affinity or by modifying > them manually). default_smp_affinity does not help at all and there is nothing a module can modify manually. I'll send out a patch series which cleans that up soon. Thanks, tglx