From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750D7C433DB for ; Thu, 25 Mar 2021 17:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 287DE61A2D for ; Thu, 25 Mar 2021 17:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbhCYRxo (ORCPT ); Thu, 25 Mar 2021 13:53:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:50646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbhCYRxR (ORCPT ); Thu, 25 Mar 2021 13:53:17 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D9C961A2C; Thu, 25 Mar 2021 17:53:17 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lPUAV-003ngb-6P; Thu, 25 Mar 2021 17:53:15 +0000 Date: Thu, 25 Mar 2021 17:53:14 +0000 Message-ID: <87y2ebqfw5.wl-maz@kernel.org> From: Marc Zyngier To: Megha Dey Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, dave.jiang@intel.com, ashok.raj@intel.com, kevin.tian@intel.com, dwmw@amazon.co.uk, x86@kernel.org, tony.luck@intel.com, dan.j.williams@intel.com, jgg@mellanox.com, kvm@vger.kernel.org, iommu@lists.linux-foundation.org, alex.williamson@redhat.com, bhelgaas@google.com, linux-pci@vger.kernel.org, baolu.lu@linux.intel.com, ravi.v.shankar@intel.com Subject: Re: [Patch V2 13/13] genirq/msi: Provide helpers to return Linux IRQ/dev_msi hw IRQ number In-Reply-To: <1614370277-23235-14-git-send-email-megha.dey@intel.com> References: <1614370277-23235-1-git-send-email-megha.dey@intel.com> <1614370277-23235-14-git-send-email-megha.dey@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: megha.dey@intel.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, dave.jiang@intel.com, ashok.raj@intel.com, kevin.tian@intel.com, dwmw@amazon.co.uk, x86@kernel.org, tony.luck@intel.com, dan.j.williams@intel.com, jgg@mellanox.com, kvm@vger.kernel.org, iommu@lists.linux-foundation.org, alex.williamson@redhat.com, bhelgaas@google.com, linux-pci@vger.kernel.org, baolu.lu@linux.intel.com, ravi.v.shankar@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 26 Feb 2021 20:11:17 +0000, Megha Dey wrote: > > From: Dave Jiang > > Add new helpers to get the Linux IRQ number and device specific index > for given device-relative vector so that the drivers don't need to > allocate their own arrays to keep track of the vectors and hwirq for > the multi vector device MSI case. > > Reviewed-by: Tony Luck > Signed-off-by: Dave Jiang > Signed-off-by: Megha Dey > --- > include/linux/msi.h | 2 ++ > kernel/irq/msi.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 46 insertions(+) > > diff --git a/include/linux/msi.h b/include/linux/msi.h > index 24abec0..d60a6ba 100644 > --- a/include/linux/msi.h > +++ b/include/linux/msi.h > @@ -451,6 +451,8 @@ struct irq_domain *platform_msi_create_irq_domain(struct fwnode_handle *fwnode, > int platform_msi_domain_alloc_irqs(struct device *dev, unsigned int nvec, > irq_write_msi_msg_t write_msi_msg); > void platform_msi_domain_free_irqs(struct device *dev); > +int msi_irq_vector(struct device *dev, unsigned int nr); > +int dev_msi_hwirq(struct device *dev, unsigned int nr); > > /* When an MSI domain is used as an intermediate domain */ > int msi_domain_prepare_irqs(struct irq_domain *domain, struct device *dev, > diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c > index 047b59d..f2a8f55 100644 > --- a/kernel/irq/msi.c > +++ b/kernel/irq/msi.c > @@ -581,4 +581,48 @@ struct msi_domain_info *msi_get_domain_info(struct irq_domain *domain) > return (struct msi_domain_info *)domain->host_data; > } > > +/** > + * msi_irq_vector - Get the Linux IRQ number of a device vector > + * @dev: device to operate on > + * @nr: device-relative interrupt vector index (0-based). > + * > + * Returns the Linux IRQ number of a device vector. > + */ > +int msi_irq_vector(struct device *dev, unsigned int nr) > +{ > + struct msi_desc *entry; > + int i = 0; > + > + for_each_msi_entry(entry, dev) { > + if (i == nr) > + return entry->irq; > + i++; This obviously doesn't work with Multi-MSI, does it? > + } > + WARN_ON_ONCE(1); > + return -EINVAL; > +} > +EXPORT_SYMBOL_GPL(msi_irq_vector); > + > +/** > + * dev_msi_hwirq - Get the device MSI hw IRQ number of a device vector > + * @dev: device to operate on > + * @nr: device-relative interrupt vector index (0-based). > + * > + * Return the dev_msi hw IRQ number of a device vector. > + */ > +int dev_msi_hwirq(struct device *dev, unsigned int nr) > +{ > + struct msi_desc *entry; > + int i = 0; > + > + for_each_msi_entry(entry, dev) { > + if (i == nr) > + return entry->device_msi.hwirq; > + i++; > + } > + WARN_ON_ONCE(1); > + return -EINVAL; > +} > +EXPORT_SYMBOL_GPL(dev_msi_hwirq); > + > #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */ And what uses these helpers? Thanks, M. -- Without deviation from the norm, progress is not possible.