From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319B2C433ED for ; Tue, 11 May 2021 06:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1F261430 for ; Tue, 11 May 2021 06:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230129AbhEKGl0 (ORCPT ); Tue, 11 May 2021 02:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229807AbhEKGlZ (ORCPT ); Tue, 11 May 2021 02:41:25 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C18C061574 for ; Mon, 10 May 2021 23:40:19 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id n2so28090000ejy.7 for ; Mon, 10 May 2021 23:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Y4Rj8EnwtMz41SpIGL/os5eQNolfOJDLLlLCmRKOuDs=; b=YgUlJoP2FIif2tAMX6eKiKWcm5EApFrjeiDMmCjznmozQ0DnO5AdXDaQWbujyvo+MH PeZOg1D4EoNQNwlt2ySkgMJxmXODOox2KBe7/6F31DLiQOBSkIYt94NGriro+qEr/HiV 8QtJHFvN0OfOYC7atckqbI4MzHHphANYLC2OtlrPh1/YxhT6kL2oVjnrYArXwMQUYZOe BvAAPtwP65f9Y4F7EVdA+L06X1Hxj7/TmH6YSlONfOy4uSLN1nlN0Ry06zShnoTHcSXp NfufIhmfk8mRgmHUe/n4D3ApGBqD+cKkuy8E9WJmRDJcGLAdvT6/AYa6xIcv0C7229BF iUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Y4Rj8EnwtMz41SpIGL/os5eQNolfOJDLLlLCmRKOuDs=; b=K57e3Sq4bjJuh31scHrEQoh1X+QrxT0vND960MjqOHMV0zicWWDwZHsqAA4m0uCeR2 Z+F/6DQ9HGGa9oHyBr73gYM3RP1mz87eIWuF5eGSQqtYc3GL0746D9sgHXm5eOyfK0s2 9DBiZfm5mAQQlMSprOVAFtGpfNiltrKacvqanItfZ4JhNRlTRCqFJO/2AtV8Mb2QxzZz KXhQeB4Y9Hjr30oGwdo9xHVLKMnOsC2OyiBz34Y33LU8D98uLPbCAqKaxqqwrmGxuC+q s8tuqjFSynKd0mUotH26F+tQrli9EQeMPLSA+aRJQkIH4AKUg6PZbd3FNu+rDhCru3AA b20A== X-Gm-Message-State: AOAM532Wto2NxP1QMKs6QhuXL+tO2QShnbzHoGQW4VsxabQtuJwyI0TP vvgLdO0Wok1oMhjPH+gx1sc= X-Google-Smtp-Source: ABdhPJyIho3bbGTE3v2mbjmVs6euMTooVrultOhj4Y38ONC9T2e5FHKSsjqEId3QlWeO9ks7DS+xLw== X-Received: by 2002:a17:906:5052:: with SMTP id e18mr29979645ejk.112.1620715218066; Mon, 10 May 2021 23:40:18 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:c3ab:ee01:d547:2c4e? ([2a02:908:1252:fb60:c3ab:ee01:d547:2c4e]) by smtp.gmail.com with ESMTPSA id w19sm13618954edd.52.2021.05.10.23.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 23:40:17 -0700 (PDT) Subject: Re: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit To: Andrey Grodzovsky , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org, daniel.vetter@ffwll.ch, Harry.Wentland@amd.com Cc: ppaalanen@gmail.com, Alexander.Deucher@amd.com, gregkh@linuxfoundation.org, helgaas@kernel.org, Felix.Kuehling@amd.com References: <20210510163625.407105-1-andrey.grodzovsky@amd.com> <20210510163625.407105-5-andrey.grodzovsky@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <8805dbc5-a607-a36a-d069-6c7c8b72a6b3@gmail.com> Date: Tue, 11 May 2021 08:40:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210510163625.407105-5-andrey.grodzovsky@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Am 10.05.21 um 18:36 schrieb Andrey Grodzovsky: > Helps to expdite HW related stuff to amdgpu_pci_remove > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 ++- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > index 5f6696a3c778..2b06dee9a0ce 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > @@ -170,7 +170,7 @@ void amdgpu_amdkfd_device_init(struct amdgpu_device *adev) > } > } > > -void amdgpu_amdkfd_device_fini(struct amdgpu_device *adev) > +void amdgpu_amdkfd_device_fini_sw(struct amdgpu_device *adev) > { > if (adev->kfd.dev) { > kgd2kfd_device_exit(adev->kfd.dev); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h > index 14f68c028126..f8e10af99c28 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h > @@ -127,7 +127,7 @@ void amdgpu_amdkfd_interrupt(struct amdgpu_device *adev, > const void *ih_ring_entry); > void amdgpu_amdkfd_device_probe(struct amdgpu_device *adev); > void amdgpu_amdkfd_device_init(struct amdgpu_device *adev); > -void amdgpu_amdkfd_device_fini(struct amdgpu_device *adev); > +void amdgpu_amdkfd_device_fini_sw(struct amdgpu_device *adev); > int amdgpu_amdkfd_submit_ib(struct kgd_dev *kgd, enum kgd_engine_type engine, > uint32_t vmid, uint64_t gpu_addr, > uint32_t *ib_cmd, uint32_t ib_len); > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > index 357b9bf62a1c..ab6d2a43c9a3 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > @@ -858,10 +858,11 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd, > return kfd->init_complete; > } > > + > + Looks like unnecessary white space change to me. > void kgd2kfd_device_exit(struct kfd_dev *kfd) > { > if (kfd->init_complete) { > - kgd2kfd_suspend(kfd, false); Where is the call to this function now? Christian. > device_queue_manager_uninit(kfd->dqm); > kfd_interrupt_exit(kfd); > kfd_topology_remove_device(kfd);