From: "Kenneth R. Crudup" <kenny@panix.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures
Date: Sun, 27 Dec 2020 21:43:49 -0800 (PST) [thread overview]
Message-ID: <88d569d8-09c-6bfc-c246-f4989bfbc1@panix.com> (raw)
In-Reply-To: <20201228040513.GA611645@bjorn-Precision-5520>
OK, got more info:
On Sun, 27 Dec 2020, Bjorn Helgaas wrote:
> If it's convenient, can you try the patch below? If the debug patch
> doesn't help:
> - Are you seeing the hibernate/resume problem when on AC or on
> battery?
OK, so:
- on TLP, before your patch, it panic()s on AC, but not on battery
- on TLP, with your patch, it panic()s on battery, but NOT on AC
- if TLP is masked, it still panic()s, but I forget if AC or battery
- even if I mask TLP, with your commit in place it panic()s
> - If you revert 4257f7e008ea, does hibernate/resume work fine? Both
> with the tlp tweak and without?
Definitely with the revert everything works. I'll try your patch after the
revert and see if anything changes.
-Kenny
--
Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Orange County CA
next prev parent reply other threads:[~2020-12-28 5:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 4:05 Commit 4257f7e0 ("PCI/ASPM: Save/restore L1SS Capability for suspend/resume") causing hibernate resume failures Bjorn Helgaas
2020-12-28 4:41 ` Kenneth R. Crudup
2020-12-28 5:43 ` Kenneth R. Crudup [this message]
2020-12-28 6:30 ` Kenneth R. Crudup
2020-12-30 6:55 ` Vidya Sagar
2021-01-22 20:11 ` Kenneth R. Crudup
2021-01-27 15:50 ` Bjorn Helgaas
2021-01-27 16:00 ` Kenneth R. Crudup
2021-01-27 16:03 ` Kenneth R. Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d569d8-09c-6bfc-c246-f4989bfbc1@panix.com \
--to=kenny@panix.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).