From: Ray Jui <ray.jui@broadcom.com>
To: bjorn@helgaas.com
Cc: Bjorn Helgaas <helgaas@kernel.org>, Wei Liu <wei.liu@kernel.org>,
linux-pci@vger.kernel.org, rjui@broadcom.com,
Andrew Murray <andrew.murray@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] PCI: iproc: move quirks to driver
Date: Wed, 11 Dec 2019 16:05:23 -0800 [thread overview]
Message-ID: <8983ae6c-36ac-7acc-5caa-2d11bf593d44@broadcom.com> (raw)
In-Reply-To: <CABhMZUU82iRD67yQhpUG3MUx3s9WaZ=tAXA=QriEEjUkNbu22w@mail.gmail.com>
On 12/11/19 4:02 PM, Bjorn Helgaas wrote:
> On Wed, Dec 11, 2019 at 5:40 PM Ray Jui <ray.jui@broadcom.com> wrote:
>>
>>
>>
>> On 12/11/19 2:34 PM, Bjorn Helgaas wrote:
>>> On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
>>>> The quirks were originally enclosed by ifdef. That made the quirks not
>>>> to be applied when respective drivers were compiled as modules.
>>>>
>>>> Move the quirks to driver code to fix the issue.
>>>>
>>>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>>>
>>> This straddles the core and native driver boundary, so I applied it to
>>> pci/misc for v5.6. Thanks, I think this is a great solution! It's
>>> always nice when we can encapsulate device-specific things in a
>>> driver.
>>>
>>
>> Opps! I was going to review and comment and you are quick, :)
>>
>> I was going to say, I think it's better to keep this quirk in
>> "pcie-iproc.c" instead of "pcie-iproc-platform.c".
>>
>> The quirk is specific to certain PCIe devices under iProc (activated
>> based on device ID), but should not be tied to a specific bus
>> architecture (i.e., platform vs BCMA).
>
> I'm happy to move it; that's no problem.
>
Thanks, Bjorn!
next prev parent reply other threads:[~2019-12-12 0:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 17:45 [PATCH] PCI: iproc: move quirks to driver Wei Liu
2019-12-11 22:34 ` Bjorn Helgaas
2019-12-11 23:40 ` Ray Jui
2019-12-12 0:02 ` Bjorn Helgaas
2019-12-12 0:05 ` Ray Jui [this message]
2019-12-12 10:33 ` Wei Liu
2019-12-12 23:23 ` Bjorn Helgaas
2019-12-13 0:08 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8983ae6c-36ac-7acc-5caa-2d11bf593d44@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=andrew.murray@arm.com \
--cc=bjorn@helgaas.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjui@broadcom.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).