linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	linux-mips@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Huacai Chen <chenhc@lemote.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Andrew Murray <amurray@thegoodpenguin.co.uk>,
	Paul Burton <paulburton@kernel.org>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node
Date: Mon, 30 Mar 2020 23:47:32 +0800	[thread overview]
Message-ID: <90CFB680-D6DA-45E5-9E19-08F577672BA8@flygoat.com> (raw)
In-Reply-To: <68446094-263d-d0d9-df00-bc1e81c1dffe@cogentembedded.com>



于 2020年3月30日 GMT+08:00 下午11:37:21, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> 写到:
>Hello!
>
>On 03/30/2020 02:42 PM, Jiaxun Yang wrote:
>
>> Add PCI Host controller node for Loongson64 with RS780E PCH dts.
>> Note that PCI interrupts are probed via legacy way, as different
>> machine have different interrupt arrangement, we can't cover all
>> of them in dt.
>> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>  arch/mips/boot/dts/loongson/rs780e-pch.dtsi | 17 ++++++++++++++++-
>>  1 file changed, 16 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>b/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>> index 45c54d555fa4..f09599a4b9d7 100644
>> --- a/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>> +++ b/arch/mips/boot/dts/loongson/rs780e-pch.dtsi
>> @@ -5,10 +5,25 @@ bus@10000000 {
>>  		compatible = "simple-bus";
>>  		#address-cells = <2>;
>>  		#size-cells = <2>;
>> -		ranges = <0 0x10000000 0 0x10000000 0 0x10000000
>> +		ranges = <0 0x00000000 0 0x00000000 0 0x00010000 /* ioports */
>> +				0 0x10000000 0 0x10000000 0 0x10000000
>>  				0 0x40000000 0 0x40000000 0 0x40000000
>>  				0xfd 0xfe000000 0xfd 0xfe000000  0 0x2000000 /* PCI Config Space
>*/>;
>>  
>> +		pci@1a000000 {
>> +			compatible = "loongson,rs780e-pci";
>> +			device_type = "pci";
>> +			#address-cells = <3>;
>> +			#size-cells = <2>;
>> +			#interrupt-cells = <0x1>;
>
>   No need for 0x.
>
>> +
>> +			reg = <0 0x1a000000 0 0x02000000>;
>> +
>> +			ranges = <0x01000000 0x0 0x00004000 0x0 0x00004000  0x0
>0x00004000>,
>> +				<0x02000000 0x0 0x40000000 0x0 0x40000000  0x0 0x40000000>;
>
>   No need for 0x before 0 here either. And why double spaces?
 
Thanks. Will fix in next version.

The space was intent to split address and size but it seems unnecessary.

>
>> +
>> +		};
>> +
>>  		isa {
>>  			compatible = "isa";
>>  			#address-cells = <2>;
>> 
>
>MBR, Sergei

-- 
Jiaxun Yang

  reply	other threads:[~2020-03-30 15:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 11:42 [PATCH 0/5] Loongson64 Generic PCI driver Jiaxun Yang
2020-03-30 11:42 ` [PATCH 1/5] PCI: OF: Don't remap iospace on unsupported platform Jiaxun Yang
2020-03-30 11:42 ` [PATCH 2/5] PCI: Add Loongson PCI Controller support Jiaxun Yang
2020-03-30 22:08   ` Rob Herring
2020-03-30 11:42 ` [PATCH 3/5] dt-bindings: Document Loongson PCI Host Controller Jiaxun Yang
2020-03-30 15:40   ` Sergei Shtylyov
2020-03-30 15:45   ` Rob Herring
2020-03-30 11:42 ` [PATCH 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node Jiaxun Yang
2020-03-30 15:37   ` Sergei Shtylyov
2020-03-30 15:47     ` Jiaxun Yang [this message]
2020-03-30 11:42 ` [PATCH 5/5] MIPS: Loongson64: Switch to generic PCI driver Jiaxun Yang
2020-04-01  3:06 ` [PATCH v2 0/5] Loongson64 Generic PCI driver v2 Jiaxun Yang
2020-04-01  3:06   ` [PATCH v2 1/5] PCI: OF: Don't remap iospace on unsupported platform Jiaxun Yang
2020-04-01  3:06   ` [PATCH v2 2/5] PCI: Add Loongson PCI Controller support Jiaxun Yang
2020-04-01  3:06   ` [PATCH v2 3/5] dt-bindings: Document Loongson PCI Host Controller Jiaxun Yang
2020-04-01 14:18     ` Rob Herring
2020-04-01  3:06   ` [PATCH v2 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node Jiaxun Yang
2020-04-01  3:06   ` [PATCH v2 5/5] MIPS: Loongson64: Switch to generic PCI driver Jiaxun Yang
2020-04-13  5:32 ` [PATCH v3 1/5] PCI: OF: Don't remap iospace on unsupported platform Jiaxun Yang
2020-04-13  5:32   ` [PATCH v3 2/5] PCI: Add Loongson PCI Controller support Jiaxun Yang
2020-04-13  5:32   ` [PATCH v3 3/5] dt-bindings: Document Loongson PCI Host Controller Jiaxun Yang
2020-04-13  5:32   ` [PATCH v3 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node Jiaxun Yang
2020-04-13  5:32   ` [PATCH v3 5/5] MIPS: Loongson64: Switch to generic PCI driver Jiaxun Yang
2020-04-13  9:31   ` [PATCH v3 1/5] PCI: OF: Don't remap iospace on unsupported platform Sergei Shtylyov
2020-04-20  7:12 ` [PATCH v4 " Jiaxun Yang
2020-04-20  7:12   ` [PATCH v4 2/5] PCI: Add Loongson PCI Controller support Jiaxun Yang
2020-04-20  7:12   ` [PATCH v4 3/5] dt-bindings: Document Loongson PCI Host Controller Jiaxun Yang
2020-04-20  7:12   ` [PATCH v4 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node Jiaxun Yang
2020-04-20  7:12   ` [PATCH v4 5/5] MIPS: Loongson64: Switch to generic PCI driver Jiaxun Yang
2020-04-20  9:38   ` [PATCH v4 1/5] PCI: OF: Don't remap iospace on unsupported platform Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90CFB680-D6DA-45E5-9E19-08F577672BA8@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=chenhc@lemote.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=paulburton@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tsbogend@alpha.franken.de \
    --subject='Re: [PATCH 4/5] MIPS: DTS: Loongson64: Add PCI Controller Node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).