From: Chuanjia Liu <chuanjia.liu@mediatek.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: <robh+dt@kernel.org>, <bhelgaas@google.com>,
<matthias.bgg@gmail.com>, <lorenzo.pieralisi@arm.com>,
<ryder.lee@mediatek.com>, <jianjun.wang@mediatek.com>,
<yong.wu@mediatek.com>, <linux-pci@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 3/6] PCI: mediatek: Add new method to get irq number
Date: Thu, 2 Sep 2021 17:28:44 +0800 [thread overview]
Message-ID: <93f44e07917e6e194fdf62bee98f7041e9f2d546.camel@mediatek.com> (raw)
In-Reply-To: <20210831183022.GA120514@bjorn-Precision-5520>
On Tue, 2021-08-31 at 13:30 -0500, Bjorn Helgaas wrote:
> On Mon, Aug 23, 2021 at 11:27:57AM +0800, Chuanjia Liu wrote:
> > Use platform_get_irq_byname() to get the irq number
> > if the property of "interrupt-names" is defined.
>
> From patch 1/6, I have the impression that this patch is part of
> fixing an MSI issue. If so, this commit log should mention that as
> well.
Hi ,Bjorn
Yes,I will change the commit message as follow
In order to parse the new dts format that conforms to the hardware
design and fixes the MSI issue,add
platform_get_irq_byname_optional to get the irq number.
>
> > Signed-off-by: Chuanjia Liu <chuanjia.liu@mediatek.com>
> > Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > drivers/pci/controller/pcie-mediatek.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/pcie-mediatek.c
> > b/drivers/pci/controller/pcie-mediatek.c
> > index 4296d9e04240..19e35ac62d43 100644
> > --- a/drivers/pci/controller/pcie-mediatek.c
> > +++ b/drivers/pci/controller/pcie-mediatek.c
> > @@ -654,7 +654,11 @@ static int mtk_pcie_setup_irq(struct
> > mtk_pcie_port *port,
> > return err;
> > }
> >
> > - port->irq = platform_get_irq(pdev, port->slot);
> > + if (of_find_property(dev->of_node, "interrupt-names", NULL))
> > + port->irq = platform_get_irq_byname(pdev, "pcie_irq");
> > + else
> > + port->irq = platform_get_irq(pdev, port->slot);
>
> This would be the only instance of this pattern, where we look for a
> property and use the result to decide how to look for the IRQ.
>
> dw_pcie_host_init() does something like this:
>
> port->irq = platform_get_irq_byname_optional(pdev, "pcie_irq");
> if (port->irq < 0) {
> port->irq = platform_get_irq(pdev, port->slot);
> if (port->irq < 0)
> return port->irq;
> }
>
> Would that work for you? If not, the commit log should explain why
> you can't use the standard pattern.
>
> If you do things differently than other drivers, it makes things
> harder to review and slows things down. If you *have* to do
> something
> differently and it adds real value to be different, that's fine. But
> we should avoid unnecessary differences.
Thanks for your advice,it is very helpful to me, I will use standard
pattern to avoid unnecessary differences
Thanks again!
Chuanjia
>
> > if (port->irq < 0)
> > return port->irq;
> >
> > --
> > 2.18.0
> >
next prev parent reply other threads:[~2021-09-02 9:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 3:27 [PATCH v12 0/6] PCI: mediatek: Spilt PCIe node to comply with hardware design Chuanjia Liu
2021-08-23 3:27 ` [PATCH v12 1/6] dt-bindings: PCI: mediatek: Update the Device tree bindings Chuanjia Liu
2021-08-23 3:27 ` [PATCH v12 2/6] PCI: mediatek: Add new method to get shared pcie-cfg base address Chuanjia Liu
2021-08-27 16:46 ` Bjorn Helgaas
2021-08-30 7:09 ` Chuanjia Liu
2021-08-30 21:43 ` Bjorn Helgaas
2021-08-31 3:31 ` Chuanjia Liu
2021-08-31 15:17 ` Rob Herring
2021-09-02 9:34 ` Chuanjia Liu
2021-08-31 15:04 ` Rob Herring
2021-08-31 15:47 ` Bjorn Helgaas
2021-08-31 18:24 ` Rob Herring
2021-08-23 3:27 ` [PATCH v12 3/6] PCI: mediatek: Add new method to get irq number Chuanjia Liu
2021-08-31 18:30 ` Bjorn Helgaas
2021-09-02 9:28 ` Chuanjia Liu [this message]
2021-08-23 3:27 ` [PATCH v12 4/6] PCI: mediatek: Get pci domain and decide how to parse node Chuanjia Liu
2021-08-23 3:27 ` [PATCH v12 5/6] arm64: dts: mediatek: Split PCIe node for MT2712 and MT7622 Chuanjia Liu
2021-09-21 18:43 ` Matthias Brugger
2021-08-23 3:28 ` [PATCH v12 6/6] ARM: dts: mediatek: Update MT7629 PCIe node for new format Chuanjia Liu
2021-09-21 18:43 ` Matthias Brugger
2021-08-26 12:53 ` [PATCH v12 0/6] PCI: mediatek: Spilt PCIe node to comply with hardware design Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f44e07917e6e194fdf62bee98f7041e9f2d546.camel@mediatek.com \
--to=chuanjia.liu@mediatek.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).