From: You-Sheng Yang <vicamo.yang@canonical.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH] PCI: vmd: Add AHCI to fast interrupt list
Date: Tue, 8 Sep 2020 15:15:28 +0800 [thread overview]
Message-ID: <9602475e-3b20-b070-8f66-52ec5600d9eb@canonical.com> (raw)
In-Reply-To: <20200904171325.64959-1-jonathan.derrick@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1976 bytes --]
On 2020-09-05 01:13, Jon Derrick wrote:
> Some platforms have an AHCI controller behind VMD. These platforms are
> working correctly except for a case when the AHCI MSI is programmed with
> VMD IRQ vector 0 (0xfee00000). When programmed with any other interrupt
> (0xfeeNN000), the MSI is routed correctly and is handled by VMD. Placing
> the AHCI MSI(s) in the fast-interrupt allow list solves the issue.
>
> This also requires that VMD allocate more than one MSI/X vector and
> changes the minimum MSI/X vectors allocated to two.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Verified two platforms with such configuration. Thank you.
You-Sheng Yang
> ---
> drivers/pci/controller/vmd.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index f69ef8c89f72..d9c72613082a 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -202,15 +202,13 @@ static struct vmd_irq_list *vmd_next_irq(struct vmd_dev *vmd, struct msi_desc *d
> int i, best = 1;
> unsigned long flags;
>
> - if (vmd->msix_count == 1)
> - return &vmd->irqs[0];
> -
> /*
> - * White list for fast-interrupt handlers. All others will share the
> + * Allow list for fast-interrupt handlers. All others will share the
> * "slow" interrupt vector.
> */
> switch (msi_desc_to_pci_dev(desc)->class) {
> case PCI_CLASS_STORAGE_EXPRESS:
> + case PCI_CLASS_STORAGE_SATA_AHCI:
> break;
> default:
> return &vmd->irqs[0];
> @@ -657,7 +655,7 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)
> if (vmd->msix_count < 0)
> return -ENODEV;
>
> - vmd->msix_count = pci_alloc_irq_vectors(dev, 1, vmd->msix_count,
> + vmd->msix_count = pci_alloc_irq_vectors(dev, 2, vmd->msix_count,
> PCI_IRQ_MSIX);
> if (vmd->msix_count < 0)
> return vmd->msix_count;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-08 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 17:13 [PATCH] PCI: vmd: Add AHCI to fast interrupt list Jon Derrick
2020-09-08 7:15 ` You-Sheng Yang [this message]
2020-09-12 2:26 ` Keith Busch
2020-09-14 12:21 ` Derrick, Jonathan
2020-10-19 9:37 ` Jian-Hong Pan
2020-10-20 15:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9602475e-3b20-b070-8f66-52ec5600d9eb@canonical.com \
--to=vicamo.yang@canonical.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).