From: Arnd Bergmann <arnd@arndb.de> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Ben Dooks <ben.dooks@codethink.co.uk>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Magnus Damm <damm@opensource.se>, linux-pci <linux-pci@vger.kernel.org>, Linux-sh list <linux-sh@vger.kernel.org> Subject: Re: [PATCH] pci: rcar host needs OF Date: Thu, 08 May 2014 17:21:54 +0200 [thread overview] Message-ID: <9614403.Lyniq7F3TJ@wuerfel> (raw) In-Reply-To: <CAMuHMdWBzBneDqyDxK5HU3Bt_5CyRfTM_f_6YGJHokG_v17_sw@mail.gmail.com> On Thursday 08 May 2014 17:16:32 Geert Uytterhoeven wrote: > On Thu, May 8, 2014 at 5:06 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > > On 08/05/14 15:56, Arnd Bergmann wrote: > >> > >> The pci-rcar driver is enabled for compile tests, and this has > >> now shown that the driver cannot build without CONFIG_OF, > >> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF > >> interrupt mapping when possible": > >> > >> drivers/built-in.o: In function `rcar_pci_map_irq': > >> :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci' > >> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> Cc: Bjorn Helgaas <bhelgaas@google.com> > >> Cc: Magnus Damm <damm@opensource.se> > >> Cc: linux-pci@vger.kernel.org > >> Cc: linux-sh@vger.kernel.org > >> --- > >> drivers/pci/host/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > >> index fbbef0b..4675f47 100644 > >> --- a/drivers/pci/host/Kconfig > >> +++ b/drivers/pci/host/Kconfig > >> @@ -27,7 +27,7 @@ config PCI_TEGRA > >> > >> config PCI_RCAR_GEN2 > >> bool "Renesas R-Car Gen2 Internal PCI controller" > >> - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST) > >> + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST) > >> help > >> Say Y here if you want internal PCI support on R-Car Gen2 SoC. > >> There are 3 internal PCI controllers available with a single > >> > > > > This driver /should/ be able to be built for just the platform case > > so it sounds like f8f2fe7355fb stopped this but no-one has yet to > > notice. > > You mean include/linux/of_pci.h should provide a dummy version of > of_irq_parse_and_map_pci() returning 0 in case OF=n? Good idea, I'll give this patch some testing in the randconfig builder, replacing the one above. Arnd diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h index 1a1f5ff..b6f2621 100644 --- a/include/linux/of_pci.h +++ b/include/linux/of_pci.h @@ -7,7 +7,6 @@ struct pci_dev; struct of_phandle_args; int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq); -int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); struct device_node; struct device_node *of_pci_find_child_device(struct device_node *parent, @@ -19,11 +18,14 @@ int of_pci_parse_bus_range(struct device_node *node, struct resource *res); int of_pci_msi_chip_add(struct msi_chip *chip); void of_pci_msi_chip_remove(struct msi_chip *chip); struct msi_chip *of_pci_find_msi_chip_by_node(struct device_node *of_node); +int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); #else static inline int of_pci_msi_chip_add(struct msi_chip *chip) { return -EINVAL; } static inline void of_pci_msi_chip_remove(struct msi_chip *chip) { } static inline struct msi_chip * of_pci_find_msi_chip_by_node(struct device_node *of_node) { return NULL; } +static inline int +of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin) { return 0; } #endif #endif
next prev parent reply other threads:[~2014-05-08 15:22 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann [not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de> 2014-05-08 14:56 ` [PATCH] pci: rcar host needs OF Arnd Bergmann 2014-05-08 15:06 ` Ben Dooks 2014-05-08 15:16 ` Geert Uytterhoeven 2014-05-08 15:21 ` Arnd Bergmann [this message] 2014-05-09 6:59 ` Arnd Bergmann 2014-05-27 22:54 ` Bjorn Helgaas 2014-05-28 1:37 ` Jingoo Han 2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck 2014-05-09 11:48 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9614403.Lyniq7F3TJ@wuerfel \ --to=arnd@arndb.de \ --cc=ben.dooks@codethink.co.uk \ --cc=bhelgaas@google.com \ --cc=damm@opensource.se \ --cc=geert@linux-m68k.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --subject='Re: [PATCH] pci: rcar host needs OF' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).