From: Marc Zyngier <firstname.lastname@example.org> To: Remi Pommarel <email@example.com> Cc: Lorenzo Pieralisi <firstname.lastname@example.org>, Andrew Murray <email@example.com>, Ellie Reeves <firstname.lastname@example.org>, <email@example.com>, <firstname.lastname@example.org>, Bjorn Helgaas <email@example.com>, Thomas Petazzoni <firstname.lastname@example.org>, <email@example.com> Subject: Re: [PATCH v3] PCI: aardvark: Use LTSSM state to build link training flag Date: Mon, 14 Oct 2019 15:18:28 +0100 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20191014140026.GB1426@voidbox> On 2019-10-14 15:00, Remi Pommarel wrote: > On Mon, Oct 14, 2019 at 02:45:34PM +0100, Marc Zyngier wrote: >> Hi Remi, >> >> On 2019-10-14 14:06, Remi Pommarel wrote: >> > Hi Lorenzo, Marc, [...] >> > Sure, I think this could be considered a fix for the following >> commit : >> > Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI >> > bridge config space") >> > >> > Moreover, Marc, I am also a bit supprised that you did not have to >> use >> >  to even be able to boot. >> >> No, I don't have that one, and yet the system boots fine (although >> PCI >> doesn't get much use on this box). I guess I'm lucky... >> >> > Also if you want to be completely immune to this kind of SError >> (that >> > could theoretically happen if the link goes down for other reasons >> than >> > being retrained) you would have to use mainline ATF along with >> . But >> > the chances to hit that are low (could only happen in case of link >> > errors). >> >> Now you've got me worried. Can you point me to that ATF patch? I'm >> quite >> curious as to how you recover from an SError on a v8.0 CPU given >> that it >> has no syndrome information and may as well signal "CPU on fire!"... >> > > The patch is at . Please note that this is done quite similarly > for > rcar. > >  > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/1541 That patch, without any other information, looks quite flaky. Unless there is a strong guarantee that ESR_EL3.ISS==2 only when the PCIe controller goes wrong, it looks like this only papers over the issue... That's pretty much independent from the patch at hand in this thread, but I certainly wouldn't trust this ATF patch without some more information about how the fault is reported to the CPU. M. -- Jazz is not dead. It just smells funny...
next prev parent reply index Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-22 21:33 Remi Pommarel 2019-08-06 18:50 ` Remi Pommarel 2019-09-25 12:32 ` Thomas Petazzoni 2019-09-30 15:40 ` Andrew Murray 2019-09-30 16:52 ` Remi Pommarel 2019-10-01 8:05 ` Andrew Murray 2019-10-13 10:34 ` Marc Zyngier 2019-10-14 10:01 ` Lorenzo Pieralisi 2019-10-14 13:06 ` Remi Pommarel 2019-10-14 13:45 ` Marc Zyngier 2019-10-14 14:00 ` Remi Pommarel 2019-10-14 14:18 ` Marc Zyngier [this message] 2019-10-14 16:50 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-PCI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \ firstname.lastname@example.org public-inbox-index linux-pci Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci AGPL code for this site: git clone https://public-inbox.org/public-inbox.git