From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DAEC10F03 for ; Fri, 22 Mar 2019 12:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54C072054F for ; Fri, 22 Mar 2019 12:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mM01Q1Gz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389238AbfCVMdK (ORCPT ); Fri, 22 Mar 2019 08:33:10 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52322 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388584AbfCVMdK (ORCPT ); Fri, 22 Mar 2019 08:33:10 -0400 Received: by mail-wm1-f68.google.com with SMTP id a184so1991477wma.2; Fri, 22 Mar 2019 05:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RXAj0aHFadCPFYeVR3Dpi4dD8U8QNMibZrECrLsC8a4=; b=mM01Q1GzCatq02rPNvYzSv30/KZ1lyFiQFn+5Ga5qGBwkaminJmGYpcEloV8UUApC5 k9gbJztAQKV6BiGJaJKv3yauQJcT7nLwJV4mUxkoU53JWoDwSceuNaM2m9LzGqx5+zdy J4G1j1HMOC2STyHGi4FdjpQDYSfx55C+Zs95P81Sd7yifCVuJeOxjB2kelBKVE08enwc uEOUe8HeqB6oEsHCYNSWpWIKzw7dY+iNGBHVS/V6I2Aw5Q+AU5I3n5cepg8ts+1Tev93 RAscLt69fqBBg9SiMADPXrwKxeDEL0LmWr8RajV41ohf/64aBl2UEomi1F66zWhg3616 bKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RXAj0aHFadCPFYeVR3Dpi4dD8U8QNMibZrECrLsC8a4=; b=lU+VusATPj5Nci8yZESGH63pdjJ3uxZdVJDIRMO9eo4mxWF+2ZY0PmI4ssJCO57pdc k1chnOvZK6f+4n95TEYxm87lOOUQH1I5hKMmJpniLw9KBIkJo18WyaI7i9Q/vFB+Ulfx zUxAUrXFR7Q4Om2WG8RWaz1OCm65PtcP0xArDXILvu2PXM7CHDxISsac0/Pr/RZA2+dj pooHGJMe0qbks02cKklbae0H9ET1Bu0Lwe/wjI2+a34hXlOkOCoryE+yiNAAv4Fy5Z4g plKVvGP0Jnm3etKiSgzoGhrfD8mDkcwJVgwk/X27rxC+YCqNiC/5kiPTH7CHEg6kbRwk dH6g== X-Gm-Message-State: APjAAAUSQbBOa90PzlypVEAhsyZXEqXrohmhQ20nxwC+TWjkBpHlLqTi OiuYX6qUGXywyg4e7J/mJyRwCaJ6 X-Google-Smtp-Source: APXvYqwBWs+8GfBtVqnhMipTBdQm+eUxztBpj/wXmC1F5NDzi3veUkd0lVgfMkgMqIx7mlT9LE0FeA== X-Received: by 2002:a1c:40d6:: with SMTP id n205mr2918264wma.140.1553257988105; Fri, 22 Mar 2019 05:33:08 -0700 (PDT) Received: from [192.168.1.4] (ip-86-49-110-70.net.upcbroadband.cz. [86.49.110.70]) by smtp.gmail.com with ESMTPSA id n19sm6396015wmk.35.2019.03.22.05.33.06 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 22 Mar 2019 05:33:07 -0700 (PDT) Subject: Re: [PATCH V2] PCI: rcar: Add the initialization of PCIe link in resume_noirq To: Geert Uytterhoeven , Lorenzo Pieralisi Cc: linux-pci , Kazufumi Ikeda , Gaku Inami , Marek Vasut , Geert Uytterhoeven , Phil Edworthy , Simon Horman , Wolfram Sang , Linux-Renesas References: <20190217132441.15139-1-marek.vasut@gmail.com> <20190322113133.GB24257@e107981-ln.cambridge.arm.com> <95d1076c-5490-3803-f394-9a0928c2cccb@gmail.com> <20190322121822.GA26257@e107981-ln.cambridge.arm.com> From: Marek Vasut Openpgp: preference=signencrypt Message-ID: <9b432b16-35a1-c4ec-df97-8f6f854ab8b4@gmail.com> Date: Fri, 22 Mar 2019 13:33:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 3/22/19 1:29 PM, Geert Uytterhoeven wrote: > Hi Lorenzo, Marek, Hi, > On Fri, Mar 22, 2019 at 1:18 PM Lorenzo Pieralisi > wrote: >> On Fri, Mar 22, 2019 at 01:09:13PM +0100, Marek Vasut wrote: >>> On 3/22/19 12:31 PM, Lorenzo Pieralisi wrote: >>>> On Sun, Feb 17, 2019 at 02:24:41PM +0100, marek.vasut@gmail.com wrote: >>>>> From: Kazufumi Ikeda >>>>> >>>>> Reestablish the PCIe link very early in the resume process in case it >>>>> went down to prevent PCI accesses from hanging the bus. Such accesses >>>>> can happen early in the PCI resume process, in the resume_noirq, thus >>>>> the link must be reestablished in the resume_noirq callback of the >>>>> driver. >>>> >>>> This looks like a fix (most likely fixing initial S2R support, please >>>> help me chase the commit ID), should we consider it for stable kernels ? >>>> >>>> Without it I understand S2R is actually broken on platforms with this >>>> host bridge. >>> I don't think this ever worked, so it's hard to find a Fixes: commit for >>> this. >> >> If we want to send it to stable kernels we have to select which versions >> we are covering. I think the only options for a Fixes: tag are either >> the initial S2R support commit for the platforms this driver runs on >> or the initial driver commit that harks back to v3.16 AFAICS. > > This only started to become an issue when support for arm64 platforms > was added, where PSCI may power down the SoC, right? Wouldn't you also hit this on ARM32 LPAE ones ? > Hence: > Fixes: e015f88c368da1e6 ("PCI: rcar: Add support for R-Car H3 to pcie-rcar") > > Gr{oetje,eeting}s, > > Geert > -- Best regards, Marek Vasut